From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-orgmode@gnu.org
Subject: Re: Agenda filter by any tag seems to be broken
Date: Wed, 18 May 2016 11:31:49 +0800 [thread overview]
Message-ID: <87wpms3uu2.fsf@ericabrahamsen.net> (raw)
In-Reply-To: CAFyQvY2N3nVk6Ab=mgJ9R=Ttdy2iM3osgHznL3nRkg17Qf0b6w@mail.gmail.com
Kaushal Modi <kaushal.modi@gmail.com> writes:
> On Mon, May 16, 2016 at 8:38 PM Eric Abrahamsen
> <eric@ericabrahamsen.net> wrote:
>
> Starting with emacs -Q, then adding the org-plus-contrib directory
> to
> load-path:
>
> Are you installing both the git master version and org-plus-contrib? I
> do not have org-plus-contrib in my load-path. The only org I have in
> the load-path is the git master version. If you *are* installing both
> versions, then that could probably explain the issue you are facing.
I'm not running org from git anymore, just org-plus-contrib from...
melpa? Actually, since Emacs' package management has no way of
specifying "provides", I've got both org and org-plus-contrib. But
that's not the issue, see below...
> M-x org-agenda
> t ;; all todos, an empty list of course
> /
> SPC
>
> And I get the error.
>
> I tried that. But I don't get any error.
>
> I took the original org-agenda-filter-make-matcher-tag-exp function
> from the git master and added few debug statements as below:
>
> (defun org-agenda-filter-make-matcher-tag-exp (tags op)
> "Return a form associated to tag-expression TAGS.
> Build a form testing a line for agenda filter for
> tag-expressions. OP is an operator of type CHAR that allows the
> function to set the right switches in the returned form."
> (message "arg tags: %S" tags)
> (message "arg op: %S" op)
> (let (form ret)
> ;; Any of the expressions can match if OP is +, all must match if
> ;; the operator is -.
> (dolist (x tags (cons (if (eq op ?-) 'and 'or) form))
> (let* ((tag (substring x 1))
> (f (cond
> ((string= "" tag) '(not tags))
> ((and (string-match-p "\\`{" tag) (string-match-p "}\\'" tag))
Okay, there's the problem. In the org git repo, the code above has been
that way since it was added in 2015. In the package-manager version,
however, it now looks like this:
(let* ((tag (substring x 1))
(isregexp (and (equal "{" (substring tag 0 1))
(equal "}" (substring tag -1))))
regexp)
And the `substring' calls raise the error. The code is the same in the
"org" and "org-plus-contrib" packages.
I don't know where the different code comes from, or who maintains it,
or why it's different from the org git repo, but it would be nice if
someone could look into fixing that!
Eric
next prev parent reply other threads:[~2016-05-18 3:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 3:30 Agenda filter by any tag seems to be broken Eric Abrahamsen
2016-05-16 18:28 ` Kaushal Modi
2016-05-17 0:37 ` Eric Abrahamsen
2016-05-17 19:40 ` Kaushal Modi
2016-05-18 3:31 ` Eric Abrahamsen [this message]
2016-05-19 8:38 ` Nicolas Goaziou
2016-05-19 13:46 ` Eric Abrahamsen
2016-05-17 2:00 ` Eric Abrahamsen
-- strict thread matches above, loose matches on Subject: below --
2016-05-13 3:30 Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpms3uu2.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).