From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lele Gaifax Subject: [PATCH] org-colview.el: Fix typo in function name Date: Fri, 24 Jun 2016 14:26:30 +0200 Message-ID: <87wpleu615.fsf_-_@metapensiero.it> References: <20100531033853.GD27574@soloJazz.com> <87y45xgj0d.fsf@metapensiero.it> <87d1n9atgu.fsf@saiph.selenimh> <87inx1gesq.fsf@metapensiero.it> <87vb119cjj.fsf@saiph.selenimh> <87k2hgfm2h.fsf@metapensiero.it> <87bn2r7wps.fsf@saiph.selenimh> <871t3mvlfc.fsf@metapensiero.it> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGQC9-00043Z-IO for emacs-orgmode@gnu.org; Fri, 24 Jun 2016 08:26:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGQC5-0000Sp-C9 for emacs-orgmode@gnu.org; Fri, 24 Jun 2016 08:26:48 -0400 Received: from plane.gmane.org ([80.91.229.3]:34171) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGQC5-0000SZ-4w for emacs-orgmode@gnu.org; Fri, 24 Jun 2016 08:26:45 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1bGQC1-0003JV-ED for emacs-orgmode@gnu.org; Fri, 24 Jun 2016 14:26:41 +0200 Received: from 151.62.87.238 ([151.62.87.238]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 24 Jun 2016 14:26:41 +0200 Received: from lele by 151.62.87.238 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 24 Jun 2016 14:26:41 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org >>> BTW, in lisp/org-colview.el there is what seems a typo in the name of the >>> function `org-columns-hscoll-title`: since accordingly with "git grep" it is >>> referenced in two places and only in that source, is the following >>> acceptable? >> >> Sure. Could you provide a proper commit message and send the patch using >> "git format-patch" command? See >> for details. Here it is! >From 7919e3ecb9362451a2f1f5e919e378dadadaf8de Mon Sep 17 00:00:00 2001 From: Lele Gaifax Date: Fri, 24 Jun 2016 14:14:34 +0200 Subject: [PATCH] org-colview.el: Fix typo in function name * lisp/org-colview.el (org-columns-hscroll-title): rename from `org-columns-hscoll-title' (org-columns--display-here-title): adjust reference to renamed function (org-columns-remove-overlays): likewise --- lisp/org-colview.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lisp/org-colview.el b/lisp/org-colview.el index 864b221..d26f16a 100644 --- a/lisp/org-colview.el +++ b/lisp/org-colview.el @@ -438,9 +438,9 @@ for the duration of the command.") (org-add-props " " nil 'display '(space :align-to 0)) (org-add-props (substring title 0 -1) nil 'face 'org-column-title))) (setq org-columns-previous-hscroll -1) - (add-hook 'post-command-hook 'org-columns-hscoll-title nil 'local))) + (add-hook 'post-command-hook 'org-columns-hscroll-title nil 'local))) -(defun org-columns-hscoll-title () +(defun org-columns-hscroll-title () "Set the `header-line-format' so that it scrolls along with the table." (sit-for .0001) ; need to force a redisplay to update window-hscroll (when (not (= (window-hscroll) org-columns-previous-hscroll)) @@ -463,7 +463,7 @@ for the duration of the command.") (when (local-variable-p 'org-previous-header-line-format) (setq header-line-format org-previous-header-line-format) (kill-local-variable 'org-previous-header-line-format) - (remove-hook 'post-command-hook 'org-columns-hscoll-title 'local)) + (remove-hook 'post-command-hook 'org-columns-hscroll-title 'local)) (move-marker org-columns-begin-marker nil) (move-marker org-columns-top-level-marker nil) (org-with-silent-modifications -- 2.8.1 Thank you, ciao, lele. -- nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia. lele@metapensiero.it | -- Fortunato Depero, 1929.