From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: dmg <dmg@turingmachine.org>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: bug report: ox-html with coderef links needs a space between attributes in <a> element (with patch)
Date: Tue, 24 Jan 2017 18:22:05 +0100 [thread overview]
Message-ID: <87wpdk74qq.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAEBXXD_5k+hgjXWuYEXN_fkB0qxbQQvOsn-axnRPTsjRLhVqyw@mail.gmail.com> (dmg@turingmachine.org's message of "Tue, 24 Jan 2017 02:55:55 -0800")
Hello,
dmg <dmg@turingmachine.org> writes:
> I have the following org-snippet:
>
> ---------------------------------------------------------------
> This is an example
>
> #+BEGIN_SRC sml -r -l "(*(ref:%s)*)" -n
> val x = 1
> fun f y = x + y (*(ref:f)*)
> val x = 2
> val y = 3
> val z = f(x+y) (*(ref:callf)*)
> #+END_SRC
>
> - Line [[(f)]] defines a function that, when called, evaluates body *x+y*
> in environment where *x* maps to *1* and *y* maps to the argument
> ------------------------------------------------------------------
> The HTML that it generates creates invalid HTML (one parser used by my
> university refuses to accept it :)
>
> I have inspected the code and this is where it fails: Note how there is no
> space between " and class in the <a> element:
>
>
> <li>Line <a href="#coderef-f"class="coderef"
> onmouseover="CodeHighlightOn(this, 'coderef-f');"
> onmouseout="CodeHighlightOff(this, 'coderef-f');">2</a> defines a function
> that, when called, evaluates body <b>x+y</b>
> in environment where <b>x</b> maps to <b>1</b> and <b>y</b> maps to the
> argument</li>
>
>
> I am running version 9.0.3 of org.
>
> I believe this patch will solve the issue. It simply adds a space before
> the class attribute.
It works but I eventually applied a slightly different patch. Thank you
for both the report and the patch.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2017-01-24 17:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 10:55 bug report: ox-html with coderef links needs a space between attributes in <a> element (with patch) dmg
2017-01-24 17:22 ` Nicolas Goaziou [this message]
2017-01-24 19:43 ` D M German
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpdk74qq.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=dmg@turingmachine.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).