emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Dale <dale@codefu.org>, emacs-orgmode@gnu.org
Subject: Re: Is doc/org-version.tex generation broken?
Date: Fri, 30 Jun 2017 13:29:21 -0400	[thread overview]
Message-ID: <87wp7t75am.fsf@kyleam.com> (raw)
In-Reply-To: <8737ah8s4l.fsf@kyleam.com>

Kyle Meyer <kyle@kyleam.com> writes:

> Dale <dale@codefu.org> writes:

[...]

>> Is this something screwed up in my environment or are others seeing this as
>> well?
>
> I'm guessing that I should rewrite the command in a more portable way.
> Not sure what that is offhand.

Can you verify that the below change works on your system?

Thanks.

-- >8 --
Subject: [PATCH] doc/Makefile: Use printf to generate org-version.tex

* doc/Makefile (org-version.tex): Use printf instead of echo to
increase portability.

By default GNU coreutil's echo disables the interpretation of
backslash escapes (-E option), but this isn't the case for some echo
variants.

Reported-by: Dale <dale@codefu.org>
<https://lists.gnu.org/archive/html/emacs-orgmode/2017-06/msg00619.html>
---
 doc/Makefile | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/Makefile b/doc/Makefile
index 87f8c2781..e17d4415b 100644
--- a/doc/Makefile
+++ b/doc/Makefile
@@ -34,11 +34,11 @@ org-version.inc:	org.texi
 	@echo "@set DATE $(DATE)" >> org-version.inc
 
 org-version.tex:	orgcard.tex
-	@echo "org-version: $(ORGVERSION) ($(GITVERSION))"
-	@echo "% automatically generated, do not edit"  > org-version.tex
-	@echo "\def\orgversionnumber{$(ORGVERSION)}" >> org-version.tex
-	@echo "\def\versionyear{$(YEAR)}" >> org-version.tex
-	@echo "\def\year{$(YEAR)}" >> org-version.tex
+	@printf "org-version: $(ORGVERSION) ($(GITVERSION))\n"
+	@printf "%% automatically generated, do not edit\n" > org-version.tex
+	@printf "\def\orgversionnumber{$(ORGVERSION)}\n" >> org-version.tex
+	@printf "\def\\\\versionyear{$(YEAR)}\n" >> org-version.tex
+	@printf "\def\year{$(YEAR)}\n" >> org-version.tex
 
 install:	org
 	if [ ! -d $(DESTDIR)$(infodir) ]; then $(MKDIR) $(DESTDIR)$(infodir); else true; fi ;
-- 
2.13.2

  reply	other threads:[~2017-06-30 17:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-30 13:25 Is doc/org-version.tex generation broken? Dale
2017-06-30 14:08 ` Michael Ax
2017-06-30 14:30 ` Kyle Meyer
2017-06-30 17:29   ` Kyle Meyer [this message]
2017-07-01  3:46     ` Dale

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wp7t75am.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=dale@codefu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).