From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] Fix alphabetic sorting for headlines, tags
Date: Mon, 12 Feb 2018 14:59:49 +0100
Message-ID: <87woziux4a.fsf@nicolasgoaziou.fr>
References: <87bmgvbiiq.fsf@nicolasgoaziou.fr>
	<20180212084604.30122-1-seb@wirrsal.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59096)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1elEeC-0006V7-3q
	for emacs-orgmode@gnu.org; Mon, 12 Feb 2018 08:59:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1elEeB-0005Bp-0h
	for emacs-orgmode@gnu.org; Mon, 12 Feb 2018 08:59:56 -0500
Received: from relay2-d.mail.gandi.net ([2001:4b98:c:538::194]:56939)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1elEeA-00059n-QS
	for emacs-orgmode@gnu.org; Mon, 12 Feb 2018 08:59:54 -0500
In-Reply-To: <20180212084604.30122-1-seb@wirrsal.net> ("Sebastian
	=?utf-8?Q?Reu=C3=9Fe=22's?=
	message of "Mon, 12 Feb 2018 09:46:04 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Sebastian =?utf-8?Q?Reu=C3=9Fe?= <seb@wirrsal.net>
Cc: emacs-orgmode@gnu.org

Hello,

Sebastian Reu=C3=9Fe <seb@wirrsal.net> writes:

> * org.el (org-sort-entries): Use collated sorting.
> (org-tags-sort-function): Use collated sorting.
> (org-string-collate-greaterp): Add helper-function to use as defcustom
> option, since there is no =E2=80=98string-collate-greaterp=E2=80=99 in Em=
acs.
>
> * org-compat.el (org-string-collate-lessp): Add proxy to fall-back on
> string-lessp when string-collate-lessp is missing (Emacs =E2=89=A4 24).
>
> * test-org.el (test-org/string-collate-lessp): Add test.
> (test-org/sort-entries): Add regression test for non-ASCII inputs.
>
> =E2=80=98org-sort-entries=E2=80=99 and =E2=80=98org-tags-sort-function=E2=
=80=99 advertise alphabetic
> sorting, but actually sort based only on character code.  This
> produces non-alphabetic orderings of strings in non-ASCII locales.
>
> E.=E2=80=AFg., German Umlauts =E2=80=9C=C3=84 =C3=9C =C3=96=E2=80=9D are =
alphabetically sorted as if they
> were =E2=80=9CA U O=E2=80=9D, whereas sorting based on character-code wil=
l place them
> after =E2=80=9CZ=E2=80=9D, which is unexpected.

Applied. Thank you.

Regards,

--=20
Nicolas Goaziou                                                0x80A93738