From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jack Kamm <jackkamm@gmail.com>
Subject: Re: Bug or not a bug? dot expansion in ob-shell
Date: Sat, 29 Feb 2020 21:58:10 -0800
Message-ID: <87wo84ehvx.fsf@gmail.com>
References: <CA+A2iZaziAfMeGpBqL6qGrzrWEVvLvC0DUw++T4gCF3NGuW-DQ@mail.gmail.com>
 <87y2sy3kkl.fsf@ucl.ac.uk> <87r1yq4xiz.fsf@gnu.org>
 <875zg2kcy0.fsf@ucl.ac.uk> <87h7zmiw0v.fsf@gmail.com> <871rqqag19.fsf@bzg.fr>
 <87wo8iitzz.fsf@ucl.ac.uk> <87ftf63d79.fsf@gnu.org>
 <87pnear7tl.fsf@ucl.ac.uk> <87v9o236v1.fsf@gnu.org>
 <CAGY83EddDG1oi=pA+EDm41WNbhK0wb=oMGk1TDO2rY4z7LKSqw@mail.gmail.com>
 <8736b66z6t.fsf@gnu.org> <877e0h571l.fsf@alphaville.usersys.redhat.com>
 <878skwbc3g.fsf@bzg.fr> <8736b36492.fsf@alphaville.usersys.redhat.com>
 <87imjyoi99.fsf@gnu.org> <87y2slqudr.fsf@gmail.com>
 <87y2sltnas.fsf@gmail.com>
 <CA+G3_POpw2nCzrvauAAMUkpw__jfzXfvceUcJ0+AKg3Je7GCVQ@mail.gmail.com>
 <87d09wd8c5.fsf@gmail.com>
 <CA+G3_PMEacwas6Nwhwv4gungO3iCuGVm17zUQbqeg9AdNYR1Dg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:34585)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <jackkamm@gmail.com>) id 1j8HdR-0005KF-VS
 for emacs-orgmode@gnu.org; Sun, 01 Mar 2020 00:59:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <jackkamm@gmail.com>) id 1j8HdQ-0000RW-Rd
 for emacs-orgmode@gnu.org; Sun, 01 Mar 2020 00:59:29 -0500
In-Reply-To: <CA+G3_PMEacwas6Nwhwv4gungO3iCuGVm17zUQbqeg9AdNYR1Dg@mail.gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
To: Tom Gillespie <tgbugs@gmail.com>
Cc: Bastien <bzg@gnu.org>, Nick Dokos <ndokos@gmail.com>, emacs-orgmode@gnu.org

Hi Tom,

Tom Gillespie <tgbugs@gmail.com> writes:

> As with many things in emacs, I sometimes feel like I'm loosing my
> mind, or loosing track of just exactly what variables are set

You're not losing your mind. After some further testing I find that
you're right, and my understanding of the situation was incorrect.

The reason I got confused was the initial example that started this
thread:

> #+begin_src sh
>   echo .
> #+end_src
> 
> #+RESULTS:
> : 0

Which looks like it's returning the exit code. However, it turns out
that this is just a coincidence, and it's an entirely unrelated bug.

If I had read the thread more carefully, I would have seen Bastien had
already noted this here:
https://lists.gnu.org/archive/html/emacs-orgmode/2020-02/msg00716.html

I fear my confusion of the issues lead to some misinformed comments on
my part. Sorry about that. I think I wasn't the only commenter confused
about this...

Anyways, it seems the current behavior of ob-shell blocks is:

- If no ":results" specified: returns the output, transformed to a
  table. Same as the old ":results value".
- If ":results value" explicitly specified: returns the exit code. This
  is a change from the old default behavior.

I can see why you, and other regular users of ob-shell, would be annoyed
by this change of behavior.

Now that I understand what's going on, I think it would be better to
stick with the old behavior (no exit code), just fixing the original bug
that prompted this thread.