From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oNoOOhnFlF45PwAA0tVLHw (envelope-from ) for ; Mon, 13 Apr 2020 20:01:29 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id mG/PHhzFlF7aRAAAB5/wlQ (envelope-from ) for ; Mon, 13 Apr 2020 20:01:32 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 87B1F942C73 for ; Mon, 13 Apr 2020 20:01:30 +0000 (UTC) Received: from localhost ([::1]:48290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jO5Gq-0003iF-4l for larch@yhetil.org; Mon, 13 Apr 2020 16:01:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59507) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jO5GO-0003i7-2R for emacs-orgmode@gnu.org; Mon, 13 Apr 2020 16:01:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jO5GM-0003zG-BE for emacs-orgmode@gnu.org; Mon, 13 Apr 2020 16:00:59 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:34533) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jO5GM-0003yQ-5i for emacs-orgmode@gnu.org; Mon, 13 Apr 2020 16:00:58 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id B449AFF809; Mon, 13 Apr 2020 20:00:54 +0000 (UTC) From: Nicolas Goaziou To: Ihor Radchenko Subject: Re: [SOLVED] Re: [PATCH] Show hidden drawers when org-cycle on headlines References: <87ftdact0g.fsf@gmail.com> <87eesu2ekz.fsf@nicolasgoaziou.fr> <87d08c9i7j.fsf@gmail.com> <87ftd7agwl.fsf@localhost> <877dyj9wkc.fsf@gmail.com> <87k12j491l.fsf@localhost> Mail-Followup-To: Ihor Radchenko , stardiviner , emacs-orgmode@gnu.org Date: Mon, 13 Apr 2020 22:00:53 +0200 In-Reply-To: <87k12j491l.fsf@localhost> (Ihor Radchenko's message of "Tue, 14 Apr 2020 00:58:30 +0800") Message-ID: <87wo6jw3yi.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.70.183.199 X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 X-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Scan-Result: default: False [-1.01 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.57681475447588]; HAS_XOIP(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.51.188.0/24:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.28), country: US(-0.01), ip: 209.51.188.17(-0.58)]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; MAILLIST(-0.20)[mailman]; FREEMAIL_TO(0.00)[gmail.com]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:22989, ipnet:209.51.188.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[6]; FROM_NEQ_ENVFROM(0.00)[mail@nicolasgoaziou.fr,emacs-orgmode-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[nicolasgoaziou.fr]; HAS_LIST_UNSUB(-0.01)[]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: Ltfz8T2dbInp Hello, Ihor Radchenko writes: >> Thanks Ihor, I indeed found related code in Org Mode source. I implemented a >> similar functionality in my patch. > > Oh. I somehow missed your first message... > > Now, actually adding something to the discussion. > > FYI, there is org-cycle-include-plain-lists variable. If it is set to > 'integrate, plain lists will be included into cycling with point at > headline. This is against the logic that org-cycle only needs to be > dealing with headlines. So, I don't see your patch breaking the present > conventions in org. Yes, this `integrate' value is not great, IMO. However, plain lists have much more in common with headlines than with drawers. I still think basic cycling should not include drawers whatsoever. This is even more true for properties drawers. Note that you can already display drawers with `org-cycle', using three prefix arguments. Regards, -- Nicolas Goaziou