From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id aKFGCn/5s17baAAA0tVLHw (envelope-from ) for ; Thu, 07 May 2020 12:05:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8BgkFIv5s167EgAAbx9fmQ (envelope-from ) for ; Thu, 07 May 2020 12:05:31 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 48002940BD0 for ; Thu, 7 May 2020 12:05:29 +0000 (UTC) Received: from localhost ([::1]:48434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWfHN-00048d-Pk for larch@yhetil.org; Thu, 07 May 2020 08:05:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38424) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWfFI-0002mU-Ae; Thu, 07 May 2020 08:03:21 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:42391) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jWfFE-0005oV-3z; Thu, 07 May 2020 08:03:19 -0400 Received: by mail-wr1-x441.google.com with SMTP id s8so6065860wrt.9; Thu, 07 May 2020 05:03:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=y2QLf4H3sf60LKXPITzr9hHWzDZcbuJTYtgiA5TVhcs=; b=Acxa/QamFr/pG1Jz2IGGA8LUwjGa0Le5hem5C7/qzx4ebJh/qIcb2XWjmlf28I92CG EtTUiFZ/k0TwI/lk2Ims0MGPt1f8gRzvVFbHCvC5H0elWC9U99Zb/sc5bNlUB+SSIVVG 9vNKy7/9EJqHLFOLjEx4/pYNH0DhT0eOATN72z3VeLLFegtmJyBRHq11WfQC+gO6VfDK J/4tXMo54pgfeHvvYkDVaQXWGh1e9kRuOekOzouKoCbkWymb3yIGmnREnO6P4KFAsfz8 LP5qfE248QhPghFgWtv9SS1+AYx7n/9sPYhgj0PUcfCfRP/MYmw04N0yOPeXGG3kIL9U 1nzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=y2QLf4H3sf60LKXPITzr9hHWzDZcbuJTYtgiA5TVhcs=; b=Ol/5U7H5hyMtCUBTQYcTE3kby/Ir/XvI1ae2O1KWjgHzrqRyyf680BbOWiXzbxBETD 2Xf9CHgU1EhQ2bxuareUXywGP9hjBV5GQn51ic5Zbq2Bucr+WtovaYG4NoG5U2H4UniX L7UfYJb9hti2kLjDtu5ZxHqOIB534UM/Zi+MskZD7p7k0PMnq+vkea8mUsdnEShs63KV 5NYQFDTEkbok2QZjK82+vYrJhdrr0N9YnQgEx1HW1Sn0CZbka+SkdK3RWxVvnJVr6dzj nxS3G2WvFkxQ5J6K9a55X1QboZswa84LqDUZ1+pYGlKuZVSpzLwUKrUBbz+bjZFZpqu/ mmOA== X-Gm-Message-State: AGi0PubSjw01wRGjYW3/rH65ASobg2JD8g62M9+btzGZSJfZMf4Ii4LM DKNjQ8RBMDgC8NUzytp3ZFQiYJgBQjXYgw== X-Google-Smtp-Source: APiQypKJJrnt/FtxOQRlATxb3lSrMs+JBCA0El6Z8pKMCMAmaX6bNTSTKGnaJfE3qy/ZfoBK8l9tGQ== X-Received: by 2002:a5d:4685:: with SMTP id u5mr14152525wrq.98.1588852992864; Thu, 07 May 2020 05:03:12 -0700 (PDT) Received: from my-little-tumbleweed (200.143.13.109.rev.sfr.net. [109.13.143.200]) by smtp.gmail.com with ESMTPSA id t71sm8095445wmt.31.2020.05.07.05.03.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 05:03:11 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Org Mode list Subject: Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode References: <20200426172206.GC18629@ACM> <87y2qhnc9a.fsf@gmail.com> <20200427102311.GA4976@ACM> <87mu6xtano.fsf@gmail.com> <87k120ohsq.fsf@mail.linkov.net> <87blnbir01.fsf@nicolasgoaziou.fr> <87o8rbmbfa.fsf@mail.linkov.net> <87k11yftqo.fsf@nicolasgoaziou.fr> <87pnbqo74t.fsf_-_@gmail.com> <87ees6fp8r.fsf@nicolasgoaziou.fr> <87y2q89dx7.fsf@gmail.com> <874ksv4uv1.fsf@nicolasgoaziou.fr> <87ftcfekxt.fsf@gmail.com> <877dxpazbo.fsf_-_@gmail.com> <87ftcc9g27.fsf@nicolasgoaziou.fr> Date: Thu, 07 May 2020 14:03:10 +0200 In-Reply-To: <87ftcc9g27.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Thu, 07 May 2020 12:48:16 +0200") Message-ID: <87wo5ogdfl.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::441; envelope-from=kevin.legouguec@gmail.com; helo=mail-wr1-x441.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emacs developers Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 X-Spam-Score: -1.71 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=Acxa/Qam; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Scan-Result: default: False [-1.71 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.4979533033591]; DWL_DNSWL_FAIL(0.00)[gmail.com:server fail,2001:470:142::17:server fail]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; FREEMAIL_FROM(0.00)[gmail.com]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.11), country: US(-0.00), ip: 2001:470:142::17(-0.50)]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; MAILLIST(-0.20)[mailman]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_COUNT_FIVE(0.00)[6]; FROM_HAS_DN(0.00)[]; URIBL_BLOCKED(0.00)[nicolasgoaziou.fr:email]; FROM_NEQ_ENVFROM(0.00)[kevinlegouguec@gmail.com,emacs-orgmode-bounces@gnu.org]; MIME_GOOD(-0.10)[text/plain]; HAS_LIST_UNSUB(-0.01)[]; RECEIVED_SPAMHAUS_PBL(0.00)[109.13.143.200:received]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: JYhg4Sk0oB4P Nicolas Goaziou writes: > I fixed a typo and applied your patch. Thank you for fixing the typo in ORG-NEWS. I see you've removed ARG from the call to `newline-and-indent'; I don't have a strong opinion about this (though I don't see a reason not to keep it), but I guess the docstring of `org--newline' should be changed to match? > However, when I have to reproduce a failing test, I don't even want to > think about the recipe and rather concentrate on the results. Hence, > I expect `should' macro's body to be self-sufficient. Therefore, > I skipped this part of the patch. Fair enough; toggling the local variant of the minor mode is probably cleaner anyway! Thanks for the review, and for applying.