From: Ihor Radchenko <email@example.com>
To: "Juan Manuel Macías" <firstname.lastname@example.org>
Cc: orgmode <email@example.com>
Subject: Re: org-attach-git don't automatically commit changes
Date: Sun, 31 Jan 2021 11:33:57 +0800 [thread overview]
Message-ID: <87wnvt4w62.fsf@localhost> (raw)
Juan Manuel Macías <firstname.lastname@example.org> writes:
> The default value of `org-attach-id-dir' is "data/", and if I evaluate
> `(expand-file-name org-attach-id-dir)' on my current node, it returns a
> wrong path to the attached folder. `org-attach-sync' only works for me
> if I set in `org-attach-git-commit' the variable like this:
Does it mean that your attachment folder is set in :DIR: property?
> #+begin_src emacs-lisp
> ;; ...
> (let* ((dir (expand-file-name org-attach-id-dir))
> ;; ...
I suspect that it is a leftover from the major changes in org-attach
when :DIR: property was introduced. The org-attach-git presumes that all
the attachments in current file are stored in sub-directories located
inside org-attach-id-dir, which is no longer guaranteed. In fact, the
existing approach to treat all the attachments to all headings in
current file as files in a single git repo cannot be used. I can see two
1. Treat each attachment dir as individual git repo (breaking change for
those who are using :ID: property to build the attachment dirs)
2. Treat attachment dirs defined by :DIR: property individually and
leave the :ID:-defined attachments as they were treated before
I am in favour of the first approach since I do not like the idea of
keeping all the attachments in the whole file in a single git repo.
I think feedback from other is needed to decide what we need to do here.
P.S. Marking this as a bug.
next prev parent reply other threads:[~2021-01-31 3:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 16:03 Juan Manuel Macías
2021-01-30 5:10 ` Ihor Radchenko
2021-01-30 13:38 ` Juan Manuel Macías
2021-01-31 3:33 ` Ihor Radchenko [this message]
2021-01-31 10:29 ` Juan Manuel Macías
2021-01-31 10:52 ` Ihor Radchenko
2021-01-31 11:41 ` Juan Manuel Macías
2021-01-31 13:16 ` Juan Manuel Macías
2021-01-31 13:40 ` Ihor Radchenko
2021-01-31 14:36 ` Juan Manuel Macías
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).