emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Renato Ferreira <renatofdds@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-agenda.el: Rename org-agenda-format-item parameters
Date: Mon, 29 Mar 2021 23:20:02 -0400	[thread overview]
Message-ID: <87wntp2uql.fsf@kyleam.com> (raw)
In-Reply-To: <87tuozgh75.fsf@gmail.com>

Renato Ferreira writes:

> * org-agenda.el (org-agenda-format-item): Rename parameters so they
> don't clash with dynamic variables used by
> `org-prefix-format-compiled'.


Presumably you arrived at this patch because you hit into a particular
issue (related the lexical binding conversion in 129c33ddd).  Could you
provide a reproducer (or at least a description) for that problem?
That'd be useful for reviewing this patch, as well as assessing if the
conversion has other similar issues.

  reply	other threads:[~2021-03-30  3:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-25 19:35 [PATCH] org-agenda.el: Rename org-agenda-format-item parameters Renato Ferreira
2021-03-30  3:20 ` Kyle Meyer [this message]
2021-03-30 20:21   ` Renato Ferreira
2021-03-31  4:11     ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wntp2uql.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=renatofdds@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).