From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ULNyJe9Dh2Bx9gAAgWs5BA (envelope-from ) for ; Tue, 27 Apr 2021 00:51:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id mHArIe9Dh2BxDwAAB5/wlQ (envelope-from ) for ; Mon, 26 Apr 2021 22:51:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 53D1C2584B for ; Tue, 27 Apr 2021 00:51:26 +0200 (CEST) Received: from localhost ([::1]:33692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbA4b-0005IV-1P for larch@yhetil.org; Mon, 26 Apr 2021 18:51:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbA45-0005IA-Kd for emacs-orgmode@gnu.org; Mon, 26 Apr 2021 18:50:54 -0400 Received: from out2.migadu.com ([188.165.223.204]:63221) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbA41-0003PN-Ui; Mon, 26 Apr 2021 18:50:53 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1619477443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AtFiCCEod3wmoYw6Lv7bMkyJ+zb/eM0DOt4KBPUzTUs=; b=hcie+Hhfm3/nouua8B862lc42Bqk4sUVZG214Hi9KWS97vfH7TCz5pXWFS7RwTdKF7+Y2T N8eyNUSA9raGR0Uptc0XxnG4wFKivH8PpF8d5mDfkc5VKy+qvIsyymguzPZbvmBEwTFbX8 dUa2rlc5OCkx+XyKDGdMfgRKJLU8N7/+lxsrXlsOEMcJHhn63WztSCB0EMPlKBdSMcfATz hXgORNabfyLZy6084Sml6xH0sePjQQAQY/ZS3GiWLidtA4hBI9rt2dr6UD9noCD2THui4s GrIEKH4nR/FeinRhwjIdEWuZZi/8G09lbbbNHmDSoiTa6ZYEXmC+m/XP456EVQ== From: Kyle Meyer To: Bastien , No Wayman Subject: Re: Bug: [PATCH] define-minor-mode: prefer keyword args [9.4.5 (9.4.5-ga02a3b @ /home/n/.emacs.d/straight/build/org-plus-contrib/)] In-Reply-To: <87a6plus2v.fsf@gnu.org> References: <87y2d5mde2.fsf@gmail.com> <87a6plus2v.fsf@gnu.org> Date: Mon, 26 Apr 2021 18:50:42 -0400 Message-ID: <87wnsofynx.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: kyle@kyleam.com Received-SPF: pass client-ip=188.165.223.204; envelope-from=kyle@kyleam.com; helo=out2.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619477486; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=AtFiCCEod3wmoYw6Lv7bMkyJ+zb/eM0DOt4KBPUzTUs=; b=fBTokH/da6TkY0KhHDbJT9JDUdhqtJKSaLOaw3vUwKY+0fBtMDOcMcsgqsOO0SL0CyUDoT +r28yogCKEjWXz4EYrg9MvGa+GG2itgjLLJJUfcT1xVAOerz/AE/4yk28a4YeBnp02zFno N6U37gQf/QDJ3GxMsImMwna7T8wtipmgr2eharOEwTzDPlT7tbc9quKShlNcfNXv0a26KU 2aMP7BRSnsZZAglwJSb7kT7Ys8YZNZ2cl8qqPb96fTNIy0B70oJZk/M9CbKuX9CaKB1WQz kZvR7eYIgzP3VnVio3fbY8AAGUogBK4ZvTMSQOaFxvWsgDSTIZAxgFoS8GpdQA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619477486; a=rsa-sha256; cv=none; b=cFVL6f7LiP3xGvsCblLKc7pAiok/QN1q0WRdnDdBcbgQMldibcPaYe93oSIf9AMbiALkwZ QakGgnUMcw/gr8T3IzgUwzG3htMF+tH4iLtzxI95S+VN+FKdOEML797c+lJCW/w7CuX/UX 4xToHnbpS5L8dmywzFUrKjlfGG4KEIWn5sa1Pbm/nGLLi9ojryfFz7aDzAD42J6pV79Cm5 vmWk6u/cclVb4ADLD+BI5TBHHiz/abq0Desw19xds2IDsu4KaBCRAuwQRWkY20xFeGGZsd +YtSzrzjKdJW50LoybHhKCRaUEwt/7Uq+lmETE47cpZtgwSHfa+ZgUhnTyL9Ig== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=hcie+Hhf; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.65 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=hcie+Hhf; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 53D1C2584B X-Spam-Score: -2.65 X-Migadu-Scanner: scn0.migadu.com X-TUID: LBeoETp4fUbI Bastien writes: > Hi, > > thanks for the patch, we do indeed need to move forward for this. > > Could you propose the patch against the master branch (not the maint > branch, since this is not a bugfix) and perhaps fix *all* warnings? Thanks, but these were already taken care of by 8c29cbdef (Backport commit c45bfd3c4 from Emacs, 2021-04-18), which was merged into master with 664b65344.