From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YKIQKQqdE2FeAAEAgWs5BA (envelope-from ) for ; Wed, 11 Aug 2021 11:48:58 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id QGlpJAqdE2GgaAAAbx9fmQ (envelope-from ) for ; Wed, 11 Aug 2021 09:48:58 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D61C71B6E2 for ; Wed, 11 Aug 2021 11:48:57 +0200 (CEST) Received: from localhost ([::1]:38082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDkr1-00028P-N7 for larch@yhetil.org; Wed, 11 Aug 2021 05:48:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDki7-0004My-Uy for emacs-orgmode@gnu.org; Wed, 11 Aug 2021 05:39:43 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:60073) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDki6-0006GW-1p for emacs-orgmode@gnu.org; Wed, 11 Aug 2021 05:39:43 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 7C79F20004; Wed, 11 Aug 2021 09:39:38 +0000 (UTC) From: Nicolas Goaziou To: Anders Johansson Subject: Re: [PATCH] Fix bug assuming canonical duration units in org-agenda-format-items References: Date: Wed, 11 Aug 2021 11:39:35 +0200 In-Reply-To: (Anders Johansson's message of "Mon, 9 Aug 2021 16:41:37 +0200") Message-ID: <87wnosb9rc.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=217.70.183.200; envelope-from=mail@nicolasgoaziou.fr; helo=relay7-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: org-mode-email Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628675338; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=E1WWR6q5VzXFSjxfMT0xRJR4QuhVRII6z8cDBoz/nqg=; b=eaJqwa9uDGC8Xq5eF0dEgOHEoN6IvxnhNxwyHVeZAia9ytQHfyoyGm4Tn66YsWKOJvH+kM q/+x60hnYKlhEEMb39VIe1cj8nn/etqnX37CdGvm9Jbxh2iolo8Xz63XQbHKZRWLkOx7g2 3VXDhROXJ2kt7gcLfDucOpDtgPkcNt5gJnXCarYj2Ij9JXxg/+oCgjKZFQ9/fgiqzv9g1m EbJyJnp/MiIPE2wm8Yedv/FGec6R386kjwWgmZKG3xW0Kgm7LGSFSjL1IQ2YRV3/isTnGy sxDnN8rkVGtxYaGWzlAXBcawVIywFHg0klMx3G3pCMqZnXC3PeSJd1Z+3Lpcfw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628675338; a=rsa-sha256; cv=none; b=anNJtsbDizh02CTbspk0pfrpUznmu1NdAIGrq80mgnoSm2hzjD6FxG4wxLvadYcsyoObeA srkAknsazbQBPMqOOKHws0YTIHvjqWXxEN6k6Lf2/UspZ4zghBHTR+QYGk8FAWw/YhtxoF JFX38u5XDBaRbCiGPnhxN4Qo6oVuUsQmeDhQw7Mc0HpgnJODYdRritB6Xb8XJ550EznQGp PVx6J/ULmnEHAzvSwIjmt6e/biIjp0Ik+UdiBzstDiYX4ud4W7d+hkC78Bitjg8plr8Yba wWYAhPGb7xH01ibBuDcshDF1jfETsU4W5tde2HGNek/M7qM6ZufE5eOPod2rFA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.41 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: D61C71B6E2 X-Spam-Score: -2.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: bEkuHUfv7jcp Hello, Anders Johansson writes: > org-duration-from-minutes was called with canonical =3D t, but without > providing a corresponding format only using the canonical units. This > broke if the user=E2=80=99s org-duration-format used other than the canon= ical > units. I think a proper fix would be to change `org-duration-from-minutes' so it removes any unknown unit from what is provided from fmt or `org-duration-format', and defaults to (special . h:mm) if nothing is left. WDYT? Regards, --=20 Nicolas Goaziou