From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Anders Johansson <mejlaandersj@gmail.com>
Cc: org-mode-email <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Fix bug assuming canonical duration units in org-agenda-format-items
Date: Wed, 11 Aug 2021 11:39:35 +0200 [thread overview]
Message-ID: <87wnosb9rc.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAKJdtO880iVy_4M0==jqfSd-n3XsKXRSSBjxjmDqXJbz6qqeWw@mail.gmail.com> (Anders Johansson's message of "Mon, 9 Aug 2021 16:41:37 +0200")
Hello,
Anders Johansson <mejlaandersj@gmail.com> writes:
> org-duration-from-minutes was called with canonical = t, but without
> providing a corresponding format only using the canonical units. This
> broke if the user’s org-duration-format used other than the canonical
> units.
I think a proper fix would be to change `org-duration-from-minutes' so
it removes any unknown unit from what is provided from fmt or
`org-duration-format', and defaults to (special . h:mm) if nothing is
left.
WDYT?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2021-08-11 9:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 14:41 [PATCH] Fix bug assuming canonical duration units in org-agenda-format-items Anders Johansson
2021-08-11 9:39 ` Nicolas Goaziou [this message]
2021-08-31 13:55 ` Timothy
2021-08-31 15:46 ` Anders Johansson
2021-08-31 18:34 ` Nicolas Goaziou
2021-09-02 7:47 ` Anders Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnosb9rc.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=mejlaandersj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).