From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gEpjBJS+7WHGKwEAgWs5BA (envelope-from ) for ; Sun, 23 Jan 2022 21:46:12 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id uH+3AZS+7WHXIgEA9RJhRA (envelope-from ) for ; Sun, 23 Jan 2022 21:46:12 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F1A94153E7 for ; Sun, 23 Jan 2022 21:46:06 +0100 (CET) Received: from localhost ([::1]:51186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nBjkT-0008TB-6K for larch@yhetil.org; Sun, 23 Jan 2022 15:46:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBjiM-0008SM-3w for emacs-orgmode@gnu.org; Sun, 23 Jan 2022 15:43:54 -0500 Received: from mail.hostpark.net ([212.243.197.30]:43516) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBjiK-0007Rx-DE for emacs-orgmode@gnu.org; Sun, 23 Jan 2022 15:43:53 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 5509A165CB; Sun, 23 Jan 2022 21:43:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from:received :received; s=sel2011a; t=1642970628; bh=6TSwH3kWH7Fl1XzSfIx5/HNJ L2qsavqcGSW++Rww6T8=; b=hPmfTdjir1TpzUq4JLSuI2kddx7Z9daMimbKJhHz czjZcCEsu44xm3hXvh0BvihvN4Qxrq/G/cybz1gF9hgjiKy6Vv3TP+u8vtjYccqX fJ7FFq4TBqKCsinqZo2K6bPo3T2lp6dOnJVDs/JViojNvfb3TL/ZiuyYHbIu0tkn H0Y= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id qY-2zPO7m2kr; Sun, 23 Jan 2022 21:43:48 +0100 (CET) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 2A2D0165AB; Sun, 23 Jan 2022 21:43:48 +0100 (CET) From: Jonas Bernoulli To: Nicolas Goaziou Subject: Re: [PATCH v3 2/3] ox-texinfo: Optionally use @itemx for certain description list items In-Reply-To: <874k5vzswr.fsf@nicolasgoaziou.fr> References: <20211218214038.9459-1-jonas@bernoul.li> <20220118151129.19646-1-jonas@bernoul.li> <20220118151129.19646-3-jonas@bernoul.li> <874k5vzswr.fsf@nicolasgoaziou.fr> Date: Sun, 23 Jan 2022 21:43:48 +0100 Message-ID: <87wniqi3nf.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: none client-ip=212.243.197.30; envelope-from=jonas@bernoul.li; helo=mail.hostpark.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642970767; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=SJTPu+ncRJonWfYxYw9dN7roOkXwERCNfig+iUP5cxE=; b=q1U8BIybfDkoIDTtHa0FXLDLBATEPMJG6j1axffe8XsrTJh47Nj/fk6qOD8If61Z1Vf6k3 7ixZM1hAZZ/Q4xmxyky0vQc9PaH9p4iHjL0zh+bqEYfYDlT5ZIIQOgnoxyGXUFmJ3DW99O t1QavkOPWsXKqNYjBj7c3C5oCch4gRWlPkSzdsq0CFOTwLR0IiwKwJ+sBuMGklCemIiJsJ f6chUGAKQVQ/rOUD0PQqyVbYbBChAyggGflc1uHvl3hhgpZRtTXIG/E0gYAkGU30hgc36I xczShBn8uJhJ7w/y+N5d1Pu8zp6V2wA5a5p3FdlMgXvjD5xUlV81f2x6unnV7g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642970767; a=rsa-sha256; cv=none; b=orEg8BbqRsytsF3KKNBx6NPSa9ny1DZl2V5+ioRNvgQ1Fur+dsLwBj0/L/SKgXheeXo7k8 Px1RxnR78OFKWRXVWbyMDAaNxB/SGJGXGwVRCXK9i0L5imVLqlg0a9pbYIux5+YtWMBfUd UrwPs2fKXVY9Wwdlj1IH6nbVcucSWOZxnEdi7D1QtA1v+eAOR3DRioq7e9uAXbF4UvwSPq kiYgMES/Oa4Abk+9GzZTael3DTZ3AQn9DGIsQts1wfeaRYrcp9qoiIW0ud1NXrCB+EfqMN vmIsfWHrkSV8miz6b7eLXZV5wyU3G5/Ib5VNHS+QdTCVnp14Ql4/5GT/CZdRVQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=bernoul.li header.s=sel2011a header.b=hPmfTdji; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.21 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=bernoul.li header.s=sel2011a header.b=hPmfTdji; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: F1A94153E7 X-Spam-Score: -3.21 X-Migadu-Scanner: scn1.migadu.com X-TUID: +z31Jjo3cNx3 Nicolas Goaziou writes: >> - (items (and tag >> - (let ((tag (org-export-data tag info))) >> + (items (org-element-property :itemx item)) >> + (items (cond (items >> + (mapcar (lambda (tag) (org-export-data tag info)) >> + (nconc items (list tag)))) >> + ((not tag) nil) >> + (t >> + (setq tag (org-export-data tag info)) > > OK, but I think this is a bit convoluted. I wonder if we need > `org-texinfo--combine-items' at all. I.e., `org-texinfo-item' could > decide to prefix current tag with @itemx if 1) the item is empty 2) the > list has a non-nil :compact attribute 3) there's another item following > it. IOW, we do not need to rely on an :itemx property. Yes, `org-texinfo--combine-items' wasn't necessary and its better without it. But just like when crossing the street we now have to look in both directions. ;) I have kept the :compact and :sep code-paths apart because mixing them would result in something that resembles the code you called convoluted and because I think it would not make sense to mix the two styles in the same list anyway. Jonas