From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OO2OCgHLyGKo4gAAbAwnHQ (envelope-from ) for ; Sat, 09 Jul 2022 02:25:37 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 4FV5CgHLyGITsQAA9RJhRA (envelope-from ) for ; Sat, 09 Jul 2022 02:25:37 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BFC86824A for ; Sat, 9 Jul 2022 02:25:36 +0200 (CEST) Received: from localhost ([::1]:43046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9yHv-00070y-Ff for larch@yhetil.org; Fri, 08 Jul 2022 20:25:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9yGF-0006zy-Dz for emacs-orgmode@gnu.org; Fri, 08 Jul 2022 20:23:53 -0400 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]:45789) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9yGC-00050A-3p for emacs-orgmode@gnu.org; Fri, 08 Jul 2022 20:23:49 -0400 Received: by mail-pf1-x42a.google.com with SMTP id y9so345236pff.12 for ; Fri, 08 Jul 2022 17:23:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=jfa1xqJH/1mXpgpWg/PmPKFEW4tljZgbh7d26597f/s=; b=KnWnnj2rFW2+r1bWSpGkuy/mYghXsDOX4OQQK6SvcQo6AfWfjeuscGD2F9YOsb1SU+ PX7x7W3maXMW2HlVaRWZUGAxEiX33dPgWjXXzP3da+QuVyofuVbwFbKg8l5nn3H/sFI+ GrkxlVYwydp6bKkj1u+lY82Lv5HflOVXZ/sUXtYxgv8VbD4ZgcuZvhCi++Mf3itdLPy0 e1MU9THQOS3KCBZgKCtNfZrrNIfngM/ZlS7g9wq2PJbzvDaV+znZBrZrsGYv2xYAZ6nn r10Da/ouXP3TLe5ySSclexZlOFiIx6kAlhzAMRyMTytFcxOh7AbH2q+7x0rmYHlsYW0E zwQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:cc:subject:in-reply-to:references :date:message-id:mime-version:content-transfer-encoding; bh=jfa1xqJH/1mXpgpWg/PmPKFEW4tljZgbh7d26597f/s=; b=0nWMD+ws2hBfd+rpisW/quEUmHNZFOpzNLFY5xpMIxMYvV5yAVcZZ66vy1ps3t4vIq IaUa3uscEEoBtXy8hM/OgSPsaAqa5NZxEQRih/JdkuwIIy6iNAegxZxQjaAHNcRQz4HH YyxiDOH8VreWGMsulvn9At0ybZOi/7gbVeFhMB2yagEijDGKAjpaFQ4N16PAvmxZC0CO VT3fBCYY0N/1ZPr1LGx/O8gJIgc4qkSQWs1ak/wiDGSw/iYpccBqgeU5C5W6x6KO7qKI yONQ1MqlLy+RspNO/zyut7Kuso+u5+57u7DZgv+bK91wY4Bk7CfdDXMzhbnKSnKvBkcX /bSQ== X-Gm-Message-State: AJIora+DClagfCDWEezusE5aVxNqwYXKkoJnFg8d6J6tI87nsaRv3Svr rXnIvMkYBgF1PFiwZW7GXPvRi/bXdk0s5w== X-Google-Smtp-Source: AGRyM1syr936QaLEf8bHhV7D62F4dJ8aRmSpCfIm8pJntotZurG0ozyf1YRGcJanqvYMiYnDjwW/ew== X-Received: by 2002:aa7:9519:0:b0:528:c2e0:b7ae with SMTP id b25-20020aa79519000000b00528c2e0b7aemr6268048pfp.39.1657326226170; Fri, 08 Jul 2022 17:23:46 -0700 (PDT) Received: from ryzen3950 (c-208-82-98-189.rev.sailinternet.net. [208.82.98.189]) by smtp.gmail.com with ESMTPSA id y3-20020a17090ad0c300b001ef7655fcc0sm24705pjw.10.2022.07.08.17.23.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jul 2022 17:23:45 -0700 (PDT) From: Matt Huszagh To: Timothy Cc: Ihor Radchenko , emacs-orgmode@gnu.org Cc: Subject: Re: [PATCH] Fix caption format for custom latex src block In-Reply-To: <87pmir7ao9.fsf@gmail.com> References: <871qvrrjh6.fsf@localhost> <87zghxtor2.fsf@gmail.com> <87pmir7ao9.fsf@gmail.com> Date: Fri, 08 Jul 2022 17:23:44 -0700 Message-ID: <87wncn5e27.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::42a; envelope-from=huszaghmatt@gmail.com; helo=mail-pf1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1657326336; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=jfa1xqJH/1mXpgpWg/PmPKFEW4tljZgbh7d26597f/s=; b=fxYCgtFBloDgACqFQvrifg+EDigbF0PYqvhQDsgnLBBaXFVm9KmOoO48gxmyBVMA2Uq5EL aY/wA6UpKkCTGiHpNWQvJv0Yxj4KiwA+ihvRoTbsDtLNX8xT61+/jZ9Ssn5HeiHMkqCUtZ VZM5dAY6IXJVPKKnGnoiSE3PASiPmPtK6btcGp0s+AGfESqiMcAuhRLT19KBW9X11KV7nk HA6LhMCfqtRJC3MDt50cedzo8dHjJ8ycEGM99LFX6fkypR2aFGjOUa1EbwXCm1dp9R+R7z fourbK2QckJEwb7iQTedCuJZ3Scz0HzAD/LrR/V1lML4havE6zpOBFGdOL5wwA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657326336; a=rsa-sha256; cv=none; b=LbZF9PddUPpRNjC80WUm/PZp+M2vdBbkmmtsBJyxAuR2HZM0IaNFGrzLDYp33kbwax4y8l I295nJBLswMRN9CPoSk3/Kda3iSTdXTb2ImKzf7jM6EBeq03WrhFgkhs3MnoOl8N7G1aT/ ld2Xlh7S8MMm5Tkf7+eO9vuLJJSaKyL0LOb5DdnDvq/7TLSrYa+SiLpbp8anEUY6XrwSe4 1At0LvNaI+cP4vum2PMBURuqqg2CdzwZiCwsJW36tuHnSNE+m/PQXqoinKldj7xRJa+vMq k/4mlT26JX8NFa75QOfzliyoOdeFEcjrDpTdEhNctZK2BpiK4u6OojeMHSC7NA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=KnWnnj2r; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.15 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=KnWnnj2r; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BFC86824A X-Spam-Score: 6.15 X-Migadu-Scanner: scn0.migadu.com X-TUID: VAUTNje4A2Ep Timothy writes: > As mentioned by Ihor, you=E2=80=99ll want to take a look at the curent ve= rsion of > ox-latex, specifically `org-latex-src-block--custom' which now contains `= (?c . > ,caption)'. You may want to consider modifying `org-latex--caption/label-= string' to > accept the form `(element info &optional content-only)' or reimplementing= just the > bits needed for this purpose =E2=80=94 which ever works out nicer. Lookin= g at > `org-latex--caption/label-string' a substring approach looks quite fragil= e, though > you might be able to get away with an application of `replace-regexp-in-s= tring', > though I=E2=80=99d personally consider this a bit of a last resort. Thanks for the directions Timothy. I failed to reproduce the old issue with the latest commit to main, so it looks like this patch is no longer needed. Nice! I'll post back if I notice any issues in the future, but otherwise I'd say we can consider this closed. Matt