From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id IAdPGyjxyWPf4AAAbAwnHQ (envelope-from ) for ; Fri, 20 Jan 2023 02:40:56 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mGRXGijxyWOBegAAG6o9tA (envelope-from ) for ; Fri, 20 Jan 2023 02:40:56 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F27913815F for ; Fri, 20 Jan 2023 02:40:55 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIgO2-0006Us-Oi; Thu, 19 Jan 2023 20:40:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIgO0-0006UQ-Ht for emacs-orgmode@gnu.org; Thu, 19 Jan 2023 20:40:08 -0500 Received: from mail-qt1-x832.google.com ([2607:f8b0:4864:20::832]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pIgNx-0000Jj-Sl for emacs-orgmode@gnu.org; Thu, 19 Jan 2023 20:40:08 -0500 Received: by mail-qt1-x832.google.com with SMTP id fd15so3117755qtb.9 for ; Thu, 19 Jan 2023 17:40:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=vfcjVL5ag+ShjaGq4wF7UcvSzsb6uPBM/M3S3bMHkBE=; b=iFRKhVzJHhjVMeO8gfd9os3wm/QVuQGBgtPHvSj8MF5O2TwNjBebgszrb9oIFtQFPV QqdkoW8RGiP+ZZmGSgAsCvC20DfVsB4wPv8A6UaXcVQbb2mkTwlNv0ciOL09Mbvb11iy WKHNGlr0qQld7wa3TsMjvGpKkisqeYU4wFYOhlsXVuMlH7TEUD1kgVrygTP254aH9C5c mqW8aT4CEOE+054r4c405SRr8T9JZNbLIBfActGPUbd+uPf7F9oII4ZCFwazrwsF3tvW 4Gn/vr1SyWCm6CcSjrGku9ywBLgSQ4ZqtPZGmkXSe4f7KtaXNphUp8x7hIELsQxB0175 VxMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vfcjVL5ag+ShjaGq4wF7UcvSzsb6uPBM/M3S3bMHkBE=; b=oc5QoSgxn/xRG6siDu9bMYVBE3EU5ks4YKmbizfvdGZD82K3pAyVhy16OLxI//pjzK ewmHMTKSXw/5+E2LDihREez/rXixLXdpAtQEXgJsmaU+wvl0AlLPtzoglC9xcbgeN25K yuxQi3IQTGTRCKYMeFzqNtKD/GQy5S58fxeDwXH0bIxRWeFlnXqLUQbAE/+cbpyTztIG RLTeBooE96SO9fST0ihocF3SrEArphgtxO32VQH/m5WsGZmz8VFG7De59PzxxT1a/+IZ miRCRkY0sCc7vTLADzBVZ5SRFNCCP4h/NzHJOU9d2CoGa/dWovg+tlywv7KKSFktd5N/ qlew== X-Gm-Message-State: AFqh2kq01+FzE0Zno3tbQd4hsbXUqBzyNt7m2dT0VM5+KzsWuSneo2Xa xHsKIaTZz/U0ygdnfx0pA9IyvTo7ABk= X-Google-Smtp-Source: AMrXdXu0Y3EdaPRBQHSLaNJmr/Pvi29mPki/CSw5KQqpG7ZtHWPWpCf7skpuaPGqhZp9mhmyrSW8jg== X-Received: by 2002:a05:622a:5917:b0:3a6:8b3a:6450 with SMTP id ga23-20020a05622a591700b003a68b3a6450mr20068411qtb.54.1674178803764; Thu, 19 Jan 2023 17:40:03 -0800 (PST) Received: from nbook ([2601:82:c200:166d:7a0:14e6:e26:75bd]) by smtp.gmail.com with ESMTPSA id y6-20020a37f606000000b006fef61300fesm8286410qkj.16.2023.01.19.17.40.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 17:40:03 -0800 (PST) References: <87r0vvr2ai.fsf@gmail.com> <87358alhux.fsf@localhost> <87tu0q5m2t.fsf@gmail.com> <877cxligy6.fsf@localhost> <87fsc7e8ub.fsf@gmail.com> <87bkmve8qv.fsf@gmail.com> <87bkmu4vqg.fsf@localhost> User-agent: mu4e 1.9.14; emacs 30.0.50 From: No Wayman To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.1-137-gecb62e @ /home/n/.emacs.d/elpaca/builds/org/)] Date: Thu, 19 Jan 2023 20:38:32 -0500 In-reply-to: <87bkmu4vqg.fsf@localhost> Message-ID: <87wn5it214.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed Received-SPF: pass client-ip=2607:f8b0:4864:20::832; envelope-from=iarchivedmywholelife@gmail.com; helo=mail-qt1-x832.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674178856; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=vfcjVL5ag+ShjaGq4wF7UcvSzsb6uPBM/M3S3bMHkBE=; b=clGfrxbkHKw9r12Dve5EIExRpq7qczQ/+krb+o/elLCKQaNs/Kul+mtAW4o7GECOP6LGLO 1aXm3ayeuORNYHRTyg/m6H9qXP3p32vizUZyReusqr2nu9AAmQMw8dnQYdLRVZDxJGQk2w 7laK7zcPWUBOGtuaHRHnx90Zr+E3vQ4DhNdCujHlGwD7otvNNQSiyDN77aVZFu7uBJ+R2Y CWbLAQmKlP9FbwiYafNybznuIrAl1HOtaLCDDOs53zEw1GlXe8Vpy3yzKYBm2NAfXbAEYU a0eW8FenemJoXE2J0CtYJhivrehZvZWyl17m/zsp6hUb9t7+u1SUzdVKXxo9aA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=iFRKhVzJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674178856; a=rsa-sha256; cv=none; b=dPGk1kx9FwUIA8FsbMDctJkcqfcXvXF8aFOhS/r6lhFAKCbgOZ8pC1w+9U+1STRdnZ4mdp 1tE9Kan2sSHQyya8BvYF4aZekMkwPVoG9IJzIF4QeTMzPWFgqRq2A+ZzGRr4Sm7FrrOoJg 2mkrnxgpPAXTBAceIubjjz+Vb2qyizt2tzDgfsaaUA00mDcyOVRpWLhjJ8/rwPxVgAc1s3 7olzMtpPOBVQmAsMeKIuLHJ6gC5oGmmiLu3mlAaQyYFHmnC1mh/jwHpUgqv+VSdHauN/5S jn/hA3xQ0yN24YnxQvANYtRK5iThA/SjZZ2riC5+KSRE9+B7DFgWJVabswjM2g== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -4.78 X-Spam-Score: -4.78 X-Migadu-Queue-Id: F27913815F Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=iFRKhVzJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-TUID: D5LqTLN8zMco Ihor Radchenko writes: > No Wayman writes: > >> No Wayman writes: >> >>> The attached patch should take care of that. > > Thanks! > > I played a bit more with the patch and noticed that remote tag > lookup is > not performed prior to _any_ make command. > For example, there is a noticeable delay on my network when > running > something as simple as make clean. > > Maybe it would be better to download the tags instead of running > ls-remote every time? I also imagine that ls-remote might pull > newer > tags compared to the actual clone. > > An alternative could be postponing git ls-remote call to when > the actual > targets using GITVERSION are being called. Feel free to take this the patch as a base to do whatever you please with it. I've run out of free time to iterate on it.