From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 8EA8AbDilmSo2QAASxT56A (envelope-from ) for ; Sat, 24 Jun 2023 14:33:52 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id qD0GALDilmR0KQEAG6o9tA (envelope-from ) for ; Sat, 24 Jun 2023 14:33:52 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 99A0526C1F for ; Sat, 24 Jun 2023 14:33:41 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=DJ2HBOFB; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1687610031; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=7iYMASzS6RKhWhWd6OBr1nRA0xQV3ZOnZfvp6kkXzD8=; b=QLmnHacJ9wrpwA1MsUcOqetrEgdmwVdBbuLv6mvZADTBy3ugqPLautf2kBJFxcAncq7Lap BzKOAiUTIuv0hv3CMRhIVODVlPUQhbbhNvEF02DWk2MHX0+9MXyIt6TvnKkW97N43hPqbP VH5PZhnz80WofFeZbNkhg48SzX4aaan54QCm0cv+mhuFivAt26RCD9VVf96Ophmo5AiotG fjxDXLd6MJWqfUo0dR2YuMQAveAp38jv4qoupqVMFdXxQIl/O6kWS1GwKCqSxHu1cEtg2F Hj1Fc2sNkXnRjAR/uqWtLHD3ZMQL7e98T0GvZz6BjmO/qkvQKCTiWBnmnRffWw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=DJ2HBOFB; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1687610031; a=rsa-sha256; cv=none; b=VkFl0nyFnp3jPH8SshCLeRkQ2YnEW0DtMOVrTUCJ3N4xkqT9a7hoBDLWfrxvkNbMk2UMRn 6LiX602GYRavrLzA6SEgge3lBjzVRRKJ7l08/R45pPAS91fmiVlIoKE/0VLhmTUan8lDAF 2egWmp8CqWC6IumKdJ7tGD11RPS0fSNtHF5u9OsHOjw0jrOX1S4zvzTCIgd91TGTHBVz4A WIhzxPRejQnSoivlOsySuS2TFnrUrYLjiysBb87pKuI6FZDcSBL+SqZYf1UfespW81YqzJ JKb+wbDwg/tZx25TARz63ielQmhvqlwCmnmSB0Xc8M4Ua+uKUO65vuN+svi5Nw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qD2RO-0005Ve-6D; Sat, 24 Jun 2023 08:32:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qD2RM-0005VV-I5 for emacs-orgmode@gnu.org; Sat, 24 Jun 2023 08:32:32 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qD2RK-0000sw-3k for emacs-orgmode@gnu.org; Sat, 24 Jun 2023 08:32:32 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id D63C8240104 for ; Sat, 24 Jun 2023 14:32:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1687609946; bh=4FtUIWw4Nhopql0Ws4jcPx6rCN4inslQiFt53RHJXfc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=DJ2HBOFBPWtRIOkEgN6hqFegIFgPDwnpGR4DzLvd1JttW/HhWG9N5jGvXwHByIKUX CuNXQ3S4xDLsGehQl4jl7uuaub5buQ1HT+4GZtG83uUNBGWszo/ew3MizWV+VvRisd My0F7BH8NccSeCgvctLdZt3u7pxwP+NhUrUvjY4XjErC9MwEOZkLp3kcqqZFsnGBKL 87LpRyvH+UPbUM+UuiOKvZlbEZChlvwZIpRUp2ZjpMDiuXlVMPL6naABMe1RVmUfEo ow6niOp2siqKyAmo07Mqmjaj3okakLwhxsRDkHxzp/q2U3FSRZiYjD2/IG7A/phH+d 64Y0WV8Gebvtw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QpD5Q1f65z6tw3; Sat, 24 Jun 2023 14:32:26 +0200 (CEST) From: Ihor Radchenko To: Nick Dokos Cc: emacs-orgmode@gnu.org Subject: Re: [BUG] org-babel-tangle: Header arg `:comments org' produces no comment in the output [9.7-pre (release_9.6.6-418-g294a4d @ /home/nick/src/emacs/org/org-mode/lisp/)] In-Reply-To: <87352hk0nt.fsf@alphaville.usersys.redhat.com> References: <87bkh8k3at.fsf@alphaville.usersys.redhat.com> <87r0q3ddnb.fsf@localhost> <87352hk0nt.fsf@alphaville.usersys.redhat.com> Date: Sat, 24 Jun 2023 12:37:21 +0000 Message-ID: <87wmzt6npa.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -6.23 X-Spam-Score: -6.23 X-Migadu-Queue-Id: 99A0526C1F X-TUID: y1IS1I0ttLxS Nick Dokos writes: > A couple of nits: maybe the comment that `org-back-to-heading' sets match > data should be deleted? And there is a typo in the initial comment of > the test you added (thanks for adding it!): `:commends org' should be > `:comments org'. Thanks! Fixed, on bugfix. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=f56ca5009 > Also, I found a couple of places in the code where `org-back-to-heading' is called > and then match data are used. I don't know if there is a problem or not, but it might > be worth double checking to make sure that the usage makes sense: > > - org.el: l.20792 in `org-forward-heading-same-level' > - org-mouse.el: l.976 in `org-mouse-transform-to-outline' Right. Fixed, on bugfix. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=57bb9cada https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=0a842cc94 -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at