From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id YLZxOwgF52SqKQAASxT56A (envelope-from ) for ; Thu, 24 Aug 2023 09:21:45 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id cPIvOwgF52S+7gAAauVa8A (envelope-from ) for ; Thu, 24 Aug 2023 09:21:44 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6A217475C9 for ; Thu, 24 Aug 2023 09:21:44 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="HPnN3/Mz"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692861704; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=SKf3jhsAmvTnR4h8rbJB9QoAbFfL4J5d6658I+yCQlo=; b=u1Qj+49unKHCYgWU5c23N+CZCaj02bGShtcDyem81aqn7z48BEoBIFYkiL2eoUmIAc6VOy xVX0uDJfGQl1aJ08B6xBas8/MuEP0khg6YrlSGSWYEG3qUrEPOT2TIUoKUGOzo1Krnl2Y6 EZ5pxfQQyR4jK+lcyNKqWumpYrQjvzv0+BqEP1XpRt8XyMuPi4uth7cq5uMn3o5Iijogj0 4v4EYxuFVEwX3f6Aqbw64YFnl1UrZqfqMvMsG0Ydd86pimRlKLvGpIU/s3vYHBJqlOf7Gm Bzd+JuQqD7RAC/PE7HPkLqi5KPg97gwnZzz0vkSnRp+MuNhGDyx6DarensLsyA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="HPnN3/Mz"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692861704; a=rsa-sha256; cv=none; b=rrMzDxAYniAj3/SvNRTOiq7PhaD+I9jvIqvqpxO/6ShL2DiCQWnwbj8tuaUAUAlyHtfwx2 XEvbBF6b+Fv1sHopVbqFvgQrmmu6055U9l1fBMwxCPCTnP1V9NXpJYuP8wZy2L6g1SCzZJ 07DqITnpRmoNvhU2Q9FOYRN2Z+1mCpfGV1nQpudMGapKazIlqFT8bNO9AmgDt7f0WuTHV2 P811cSV9vyKCl9CFy7hE+XO7q5mOwNHrE9HAnHCVVzpovQ7TmQc4P7IYvpitAG4ICEIrRL YrdcgKQ0z5696h7R4HMvjcyMLs2M4tiYowvh17QZov66NJjt6wSRvrA9QLPF9g== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZ4dv-0003zV-Ec; Thu, 24 Aug 2023 03:20:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZ4du-0003zH-1X for emacs-orgmode@gnu.org; Thu, 24 Aug 2023 03:20:34 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZ4dr-0000N4-4i for emacs-orgmode@gnu.org; Thu, 24 Aug 2023 03:20:33 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id A7A8D240101 for ; Thu, 24 Aug 2023 09:20:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692861628; bh=YQ1ufJpcPpvdBi9trDOyZApLCjHk9THmri3KK7qtocA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=HPnN3/MzDoqqmpOrl0tzcDEapyufDYaOp7hCCQbv0vlDcsJwu7HeIzgg/yhaz0azB +SOuEW9+ZsPtHn5ZljHNw1OKUXmj69NMvtkVLAszvN+CRO3r0VXYUTe5oO7bEL1k4J Hof1yW5kfzFwoNQE19UXKc0SCkg1QEfvClhaPEqn1dun6JHJRyIzDg4ptEAF21kz0u GCcavXSqcuXMSb8tIHiSE9hGXZ00Af5NvVHWr/NE5rDQM2ScOvIRAGCid36ZnjZReo Lrp+njrIQySIvK6IrEj0Sn7UzzXzUqGRUfYnDJF3fwttljVHR6Mbaqr204mayYXwQg lgTLJnwkaGU5w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RWZHH61YNz9ry5; Thu, 24 Aug 2023 09:20:27 +0200 (CEST) From: Ihor Radchenko To: Liu Hui Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Fix docstring of `org-at-timestamp-p' In-Reply-To: References: Date: Thu, 24 Aug 2023 07:20:57 +0000 Message-ID: <87wmxk7vom.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: -9.02 X-Spam-Score: -9.02 X-Migadu-Queue-Id: 6A217475C9 X-TUID: n+Y1mJB0iq/X Liu Hui writes: > I find that the doc string of `org-at-timestamp-p' about match groups > is not consistent with the behavior. The doc string says > > ... > but for timestamps like <2023-08-23 Wed>, (when (org-at-timestamp-p) > (match-string 2)) will return the year 2023 instead of the month. This > patch corrects the group numbers. Thanks! Applied, onto bugfix, adding slightly more details to the commit message. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=973e50c83 The docstring did not correspond to the actual match data since group info was added there. So, no actual regression in the code occurred. Pure bug in the docstring. That's why bugfix. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at