From: Ihor Radchenko <yantar92@posteo.net>
To: Max Nikulin <manikulin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [FR] Should we preserve point when calling `org-open-at-point' (C-c C-o) on a heading (was: [BUG] Point position with org-open-at-point on a heading [9.6.6 (release_9.6.6 @ /usr/local/share/emacs/29.1/lisp/org/)])
Date: Mon, 23 Oct 2023 11:32:49 +0000 [thread overview]
Message-ID: <87wmvd8tge.fsf@localhost> (raw)
In-Reply-To: <877cof25vr.fsf@localhost>
Ihor Radchenko <yantar92@posteo.net> writes:
>>>> Perhaps there's some reason why
>>>> point is not preserved in this case. But for me at least, this is not
>>>> what I'd expect, and I find it somewhat disrupting, especially when
>>>> I'm working on a folded tree (defeats speed keys, etc.).
>>>
>>> I see no particular reason.
>>
>> Maybe the following is a false alarm. I hope `save-excursion' will not
>> break the "RET to open all" option, `org-open-at-point' is called
>> recursively this case.
>
> "Open all" is broken now.
>
> That said, your concern is valid - if we open internal link, it will be
> expected the point jumps to that link rather than staying on the
> heading.
I believe that I now addressed all the concerns:
1. Point position is not preserved by default.
2. When a link being open moved point in current buffer, we do allow
changing the position.
3. When multiple links are open, things should not be broken.
4. When multiple links are open and some of them (more than 1) also move
point, we move point to the position defined by the last of such
links.
Fixed, on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=098f08159
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2023-10-23 11:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 18:42 [BUG] Point position with org-open-at-point on a heading [9.6.6 (release_9.6.6 @ /usr/local/share/emacs/29.1/lisp/org/)] Gustavo Barros
2023-09-23 8:33 ` [FR] Should we preserve point when calling `org-open-at-point' (C-c C-o) on a heading (was: [BUG] Point position with org-open-at-point on a heading [9.6.6 (release_9.6.6 @ /usr/local/share/emacs/29.1/lisp/org/)]) Ihor Radchenko
2023-09-23 10:23 ` Gustavo Barros
2023-09-23 15:11 ` Max Nikulin
2023-09-24 11:00 ` Ihor Radchenko
2023-10-23 11:32 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmvd8tge.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=manikulin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).