From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Maus Subject: Re: Re: [PATCH] org-wl: Remove dependency on w3m macro `w3m-anchor' Date: Thu, 27 May 2010 10:06:38 +0200 Message-ID: <87vda9py41.wl%dmaus@ictsoc.de> References: <1274538559-13584-1-git-send-email-dmaus@ictsoc.de> <874oi0vwjc.wl%dmaus@ictsoc.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: multipart/mixed; boundary="===============1773586356==" Return-path: Received: from [140.186.70.92] (port=51816 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OHY7s-0003HD-7k for emacs-orgmode@gnu.org; Thu, 27 May 2010 04:07:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OHY7q-00079h-Af for emacs-orgmode@gnu.org; Thu, 27 May 2010 04:07:36 -0400 Received: from mysql1.xlhost.de ([213.202.242.106]:58362) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHY7q-00079L-5x for emacs-orgmode@gnu.org; Thu, 27 May 2010 04:07:34 -0400 In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: John Wiegley Cc: emacs-orgmode@gnu.org --===============1773586356== Content-Type: multipart/signed; boundary="pgp-sign-Multipart_Thu_May_27_10:06:37_2010-1"; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit --pgp-sign-Multipart_Thu_May_27_10:06:37_2010-1 Content-Type: text/plain; charset=US-ASCII John Wiegley wrote: >David Maus writes: >> Again, forgot to mention: Patch is available on >David, Can you please explain for me the rationale behind this change? Sure: The problem is, that `w3m-anchor' is not a function, but a macro. So it must be present when byte compiling org-w3m.el to be properly expanded. Declaring it an external function via `declare-function' shuts up the byte compiler but seems to place a function call into the byte compiled code that fails in runtime because `w3m-anchor' isn't a function. This results in error when using byte compiled Org mode.[1] HTH -- David [1] http://article.gmane.org/gmane.emacs.orgmode/25348 -- OpenPGP... 0x99ADB83B5A4478E6 Jabber.... dmjena@jabber.org Email..... dmaus@ictsoc.de --pgp-sign-Multipart_Thu_May_27_10:06:37_2010-1 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iF4EABEIAAYFAkv+KA0ACgkQma24O1pEeObz3QEAhL/PhWK0b9S4YjE1L2S5d9dV fhHyr55H09kJod+ulTUBAMjYxhDhlyj7y9bSoeSAU5YBS6gEaf321yHM/pJpoujD =Y3ST -----END PGP SIGNATURE----- --pgp-sign-Multipart_Thu_May_27_10:06:37_2010-1-- --===============1773586356== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --===============1773586356==--