emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: "Štěpán Němec" <stepnem@gmail.com>
To: David Maus <dmaus@ictsoc.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Make sure `flet' is fbound when executing `org-write-agenda'.
Date: Sun, 27 Jun 2010 17:00:22 +0200	[thread overview]
Message-ID: <87vd94tta1.fsf@gmail.com> (raw)
In-Reply-To: <1277649049-14463-2-git-send-email-dmaus@ictsoc.de> (David Maus's message of "Sun, 27 Jun 2010 16:30:49 +0200")

David Maus <dmaus@ictsoc.de> writes:

> * org-agenda.el (org-write-agenda): Make sure `flet' is fbound
> at runtime.
> ---
>  lisp/org-agenda.el |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 8035add..957bbf2 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -2464,6 +2464,8 @@ higher priority settings."
>  		beg (or (next-single-property-change beg 'org-filtered)
>  			(point-max))))
>  	     (run-hooks 'org-agenda-before-write-hook)
> +	     ;; make sure flet is fbound at runtime
> +	     (unless (fboundp 'flet) (require 'cl))
>  	     (cond
>  	      ((org-bound-and-true-p org-mobile-creating-agendas)
>  	       (org-mobile-write-agenda-for-mobile file))

This, while being an obvious (and correct) solution, is unfortunately
not suitable for Emacs core. You're not supposed to require the cl
package at runtime (you even get a compiler warning if you do).

Štěpán

next prev parent reply	other threads:[~2010-06-27 15:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-10 17:37 (require 'cl) seems not to be compiled manonfire
2010-06-27 10:00 ` David Maus
2010-06-27 14:30   ` [PATCH] Make sure `flet' is fbound when executing `org-write-agenda' David Maus
2010-06-27 14:30   ` David Maus
2010-06-27 15:00     ` Štěpán Němec [this message]
2010-06-27 16:01       ` [PATCH] Use backquotes to make byte compiler expand `flet' macro David Maus
2010-06-27 16:01       ` David Maus
2010-06-28  4:29         ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vd94tta1.fsf@gmail.com \
    --to=stepnem@gmail.com \
    --cc=dmaus@ictsoc.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).