From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Eric Schulte" <schulte.eric@gmail.com>
Subject: Re: Bug in babel eating my text
Date: Thu, 20 Jan 2011 09:32:28 -0700
Message-ID: <87vd1jy1i6.fsf@gmail.com>
References: <4D376B26.1050506@med.uni-goettingen.de>
	<13076.1295481297@gamaville.americas.hpqcorp.net>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from [140.186.70.92] (port=55918 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PfxWL-00088l-Ur
	for emacs-orgmode@gnu.org; Thu, 20 Jan 2011 11:38:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <schulte.eric@gmail.com>) id 1PfxWK-00032R-E7
	for emacs-orgmode@gnu.org; Thu, 20 Jan 2011 11:38:01 -0500
Received: from mail-px0-f169.google.com ([209.85.212.169]:64871)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <schulte.eric@gmail.com>) id 1PfxWK-0002vc-9c
	for emacs-orgmode@gnu.org; Thu, 20 Jan 2011 11:38:00 -0500
Received: by mail-px0-f169.google.com with SMTP id 12so192601pxi.0
	for <emacs-orgmode@gnu.org>; Thu, 20 Jan 2011 08:37:59 -0800 (PST)
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: nicholas.dokos@hp.com
Cc: Andreas Leha <andreas.leha@med.uni-goettingen.de>, emacs-orgmode@gnu.org

Nick Dokos <nicholas.dokos@hp.com> writes:

> Andreas Leha <andreas.leha@med.uni-goettingen.de> wrote:
>
>> I found a severe bug that actually eats my text, i.e. *destroys* my
>> org-mode file.
>> 
>> Or am I missing something here?
>> 
>> Just try that:
>> 
>> * Test
>> 
>>   Execute this once:
>>   #+BEGIN_src R :session test :results output silent :exports none
>>     devnull <- library("tikzDevice")
>>   #+END_src
>>  
>>   Execute this twice or more... but be careful
>>   #+BEGIN_src R :session test :results output latex :exports results
>>     tikz(console=TRUE, width=4, height=4)
>>     plot(1:2,1:2)
>>     devnull <- dev.off()
>>   #+END_src
>> 
>> * Watch me die :-(
>> 
>
> I can reproduce this: it seems to be eating one character each time it is
> executed at the end of the #+END_LaTeX. Here's a patch that seems to fix
> this problem - however, it is not based on any real understanding of the code,
> so take it with a grain of salt. Also, if this fix works, then it is likely
> that the other "wrap" cases will also need similar treatment:
>

Hi Nick,

I've just applied I generalization of your solution below, thanks for
sharing.  This is a bug that has resurfaced every time we make a change
to the insertion of results.  Hopefully this fix will be last for a
while.

Best -- Eric

>
> diff --git a/lisp/ob.el b/lisp/ob.el
> index 82625c0..2ce57ca 100644
> --- a/lisp/ob.el
> +++ b/lisp/ob.el
> @@ -1500,7 +1500,7 @@ code ---- the results are extracted in the syntax of the source
>  	   ((member "html" result-params)
>  	    (wrap "#+BEGIN_HTML\n" "#+END_HTML"))
>  	   ((member "latex" result-params)
> -	    (wrap "#+BEGIN_LaTeX\n" "#+END_LaTeX"))
> +	    (wrap "#+BEGIN_LaTeX\n" "#+END_LaTeX\n"))
>  	   ((member "code" result-params)
>  	    (wrap (format "#+BEGIN_SRC %s%s\n" (or lang "none") results-switches)
>  		  "#+END_SRC"))
>
> HTH,
> Nick