From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: Replaced obsolete interactive-p function Date: Wed, 29 Jun 2011 16:27:17 -0700 Message-ID: <87vcvojk09.fsf@gmail.com> References: <87zkl01u4y.fsf@gnu.org> <877h845l18.wl%markert.michael@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:49277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qc4An-0001el-Oo for emacs-orgmode@gnu.org; Wed, 29 Jun 2011 19:27:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qc4Am-0003uY-AX for emacs-orgmode@gnu.org; Wed, 29 Jun 2011 19:27:57 -0400 Received: from mail-iw0-f169.google.com ([209.85.214.169]:33966) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qc4Am-0003uU-1g for emacs-orgmode@gnu.org; Wed, 29 Jun 2011 19:27:56 -0400 Received: by iwn8 with SMTP id 8so1908478iwn.0 for ; Wed, 29 Jun 2011 16:27:55 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: Bastien , emacs-orgmode@gnu.org, Michael Markert Michael's patch looks great to me, I can confirm that it does stifle the warnings on Emacs24, and everything compiles and works as expected -- at least as far as the Org-mode test suite is able to differentiate. In addition to applying this patch I've also added another patch which supplies the optional KIND argument to every invocation of org-called-interactively-p. Cheers -- Eric Carsten Dominik writes: > I suggest to talk to Eric Schulte before applying this patch.... > > - Carsten > > On 30.6.2011, at 00:29, Michael Markert wrote: > >> On 29 Jun 2011, Bastien wrote: >> >>> Dear all, >>> >>> interactive-p is obsolete since Emacs 23.2 and should be replaced by >>> called-interactively-p. >>> >>> The org-called-interactively-p macro takes care of using either >>> interactive-p or called-interactively-p. >>> >>> I've just updated the latest git and Org uses >>> org-called-interactively-p wherever it makes sense. >>> >>> Please report any weird compilation warnings and/or problems. >> >> I still see a lot warnings complaining about `interactive-p'. >> I figured that it happens because the byte-compiler still sees the >> `interactive-p's >> >> Appended is a patch to the macro that checks on expand which interactive >> predicate we need. >> I don't see those warnings anymore and a quick check showed that it >> behaves as the complete version (at least on emacs24). >> >> Michael >> >> <0001-org-macs-Determine-on-macro-expand-which-interactive.patch> > > -- Eric Schulte http://cs.unm.edu/~eschulte/