From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [PATCH v2 00/11] Takjuggler exporter improvements Date: Thu, 16 Aug 2012 09:48:25 +0200 Message-ID: <87vcgjcm5y.fsf@altern.org> References: <1344164044-15059-1-git-send-email-yann.hodique@gmail.com> <1345057917-69300-1-git-send-email-yann.hodique@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:33411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1uoG-0007Vs-4f for emacs-orgmode@gnu.org; Thu, 16 Aug 2012 03:48:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1uoF-0006IA-0h for emacs-orgmode@gnu.org; Thu, 16 Aug 2012 03:48:04 -0400 Received: from mail-we0-f169.google.com ([74.125.82.169]:48103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1uoE-0006I6-QZ for emacs-orgmode@gnu.org; Thu, 16 Aug 2012 03:48:02 -0400 Received: by weys10 with SMTP id s10so1769557wey.0 for ; Thu, 16 Aug 2012 00:48:01 -0700 (PDT) In-Reply-To: <1345057917-69300-1-git-send-email-yann.hodique@gmail.com> (Yann Hodique's message of "Wed, 15 Aug 2012 21:11:45 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Yann Hodique Cc: emacs-orgmode@gnu.org Hi Yann, Yann Hodique writes: > here is a new version of the patch series. Thanks. > Changes are: > > - fixed commit messages format Thanks for this effort -- not nitpicking, but there is room left for small improvements. - The summary line should be "org-taskjuggler.el: Sentence" (note the .el after "org-taskjuggler"). - The ChangeLog entries should be sentences, starting with an uppercase letter and ending with a full stop. - It should be filled with C-x f 72 (or 70) then M-q. - "Interactive functions" = "commands" "custom variables" = "options" This makes the entries shorter and tells immediatly what it is about. All this because those entries are later on automatically parsed to get added to Emacs. I review them manually, but fixing lots of entries manually take a lot of time. I'm having a branch with your changes -- I'll apply it when you confirm you received the FSF papers. Thanks! -- Bastien