From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] ox-html: Restore wrongly omitted table attributes under HTML5. Date: Sun, 30 Jun 2013 09:35:30 +0200 Message-ID: <87vc4whwzh.fsf@gmail.com> References: <51CEF804.8070608@arfer.net> <8761wwk0gi.fsf@gmail.com> <51CF6E22.4040202@arfer.net> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtCAL-0002TX-Ok for emacs-orgmode@gnu.org; Sun, 30 Jun 2013 03:35:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UtCAK-0003bW-HK for emacs-orgmode@gnu.org; Sun, 30 Jun 2013 03:35:21 -0400 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:36871) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtCAK-0003bQ-BQ for emacs-orgmode@gnu.org; Sun, 30 Jun 2013 03:35:20 -0400 Received: by mail-wi0-f173.google.com with SMTP id hq4so2136943wib.0 for ; Sun, 30 Jun 2013 00:35:19 -0700 (PDT) In-Reply-To: <51CF6E22.4040202@arfer.net> (Kodi Arfer's message of "Sat, 29 Jun 2013 19:30:42 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Kodi Arfer Cc: emacs-orgmode@gnu.org Hello, Kodi Arfer writes: > I don't think I can. I'm not clear about the relationship between > maint and master in general, "maint" is for bugfixes only. "master" is for new features. > but it looks like maint doesn't have the bug my patch is supposed to > fix, because it doesn't treat an HTML5 doctype specially at all. You're right. Never mind then. >> One nitpick. It is more explicit to use: >> >> (and (not (org-html-html5-p info)) >> (plist-get info :html-table-attributes)) >> >> since you are using the returned value. > > Sure, I can change that. Should I base the patch off master again? I made the change before applying your patch to master. Thank you again. Also, please consider signing FSF papers for more contributions to Emacs. Regards, -- Nicolas Goaziou