From mboxrd@z Thu Jan 1 00:00:00 1970 From: torys.anderson@gmail.com (Tory S. Anderson) Subject: Agenda Holiday face doesn't work (crashes Agenda) Date: Tue, 27 Jan 2015 11:56:32 -0500 Message-ID: <87vbjs17sv.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YG9RP-0007wl-Gz for emacs-orgmode@gnu.org; Tue, 27 Jan 2015 11:56:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YG9RK-0008EY-Cn for emacs-orgmode@gnu.org; Tue, 27 Jan 2015 11:56:39 -0500 Received: from mail-yh0-x231.google.com ([2607:f8b0:4002:c01::231]:62046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YG9RK-0008EQ-9N for emacs-orgmode@gnu.org; Tue, 27 Jan 2015 11:56:34 -0500 Received: by mail-yh0-f49.google.com with SMTP id v1so6567292yhn.8 for ; Tue, 27 Jan 2015 08:56:33 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: orgmode list Hello. I've been using Julien Danjou's code to good effect: https://julien.danjou.info/blog/2010/org-mode-and-holidays Basically, it just advocates adding the following function, which then marks holidays with weekend face for clear viewing: (require 'cl-lib) (setq org-agenda-day-face-function (defun jd:org-agenda-day-face-holidays-function (date) "Compute DATE face for holidays." (unless (org-agenda-todayp date) (cl-dolist (file (org-agenda-files nil 'ifmode)) (let ((face (cl-dolist (entry (org-agenda-get-day-entries file date)) (let ((category (with-temp-buffer (insert entry) (org-get-category (point-min))))) (when (or (string= "Holiday" category) (string= "Vacation" category)) (return 'org-agenda-date-weekend)))))) (when face (return face))))))) Now, however, it has stopped working. Once again I'm receiving the error, cl-return-from: No catch for tag: --cl-block-nil--, org-agenda-date-weekend Previously I repaired this by requiring 'cl-lib and making dolist into cl-dolist; but it no longer seems to be working. I'm not sure what's changed. Any suggestions?