From mboxrd@z Thu Jan  1 00:00:00 1970
From: Oleh Krehel <ohwoeowho@gmail.com>
Subject: Unclear org-icompleting-read interface
Date: Thu, 25 Jun 2015 15:15:59 +0200
Message-ID: <87vbecudww.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50840)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ohwoeowho@gmail.com>) id 1Z877B-0007nL-Gp
	for emacs-orgmode@gnu.org; Thu, 25 Jun 2015 09:22:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ohwoeowho@gmail.com>) id 1Z8775-0005xK-JN
	for emacs-orgmode@gnu.org; Thu, 25 Jun 2015 09:22:49 -0400
Received: from mail-wg0-x231.google.com ([2a00:1450:400c:c00::231]:33088)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ohwoeowho@gmail.com>) id 1Z8775-0005ws-Dw
	for emacs-orgmode@gnu.org; Thu, 25 Jun 2015 09:22:43 -0400
Received: by wgck11 with SMTP id k11so62620044wgc.0
	for <emacs-orgmode@gnu.org>; Thu, 25 Jun 2015 06:22:42 -0700 (PDT)
Received: from firefly (dyn069045.nbw.tue.nl. [131.155.69.45])
	by mx.google.com with ESMTPSA id di7sm7616187wib.23.2015.06.25.06.22.41
	for <emacs-orgmode@gnu.org>
	(version=TLSv1.2 cipher=RC4-SHA bits=128/128);
	Thu, 25 Jun 2015 06:22:41 -0700 (PDT)
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org


Hi all,

The current `org-icompleting-read' is defined as taking only `&rest
args', which can be as many as 8, all of them without a name.

I propose to update the definition to:

    (cl-defun org-icompleting-read (prompt collection
                                    &key predicate require-match
                                      initial-input hist def inherit-input-method)
      ;; ...
      )

Let me know if you like the idea. If so, there are 43 calls to
`org-icompleting-read' in the source that need to be updated. Some of
them should as they are, since usually only the first two arguments are
used.

This change would make the calls to `org-icompleting-read' much easier
to read.

regards,
Oleh