From: Rasmus <rasmus@gmx.us>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH 8/8] ox-taskjuggler.el: allow trimming the task ID from its title
Date: Thu, 12 Nov 2015 17:49:16 +0100 [thread overview]
Message-ID: <87vb97jh83.fsf@gmx.us> (raw)
In-Reply-To: 87ziymkd0j.fsf@feelingofgreen.ru
Kosyrev Serge <_deepfire@feelingofgreen.ru> writes:
> * ox-taskjuggler.el (org-taskjuggler-trim-ids-from-titles): new custom
You should capitalize after the colon and end with a period.
Also, custom → defcustom (IMO).
> (org-taskjuggler--build-task): trim task ids from titles, when the new
> custom variable asks for this (enabled by default).
As above.
> +(defcustom org-taskjuggler-trim-ids-from-titles t
> + "Non-NIL trims the part detected as prefix from resulting task titles."
> + :group 'org-export-taskjuggler
> + :type 'boolean)
I don’t think you need to capitalize nil. Also, why is it plural?
> ;;; Hooks
> @@ -887,9 +892,16 @@ a unique id will be associated to it."
> (- org-lowest-priority org-highest-priority)))))))))
> (concat
> ;; Opening task.
> - (format "task %s \"%s\" {\n"
> - (org-taskjuggler-get-id task info)
> - (org-taskjuggler-get-name task))
> + (let* ((id (org-taskjuggler-get-id task info))
> + (raw-name (org-taskjuggler-get-name task))
> + (id-len (length id))
> + (raw-name-len (length raw-name))
> + (name (if org-taskjuggler-trim-ids-from-titles
> + (if (= raw-name-len id-len)
> + raw-name
> + (subseq raw-name (1+ id-len)))
> + raw-name)))
I would use eq, but I’m not sure it’s important. Why does
org-taskjuggler-get-name potentially return the ID? Isn’t that closer to
the misbehavior here? (Keep in mind I’m not familiar with the codebase in
question).
Rasmus
--
And I faced endless streams of vendor-approved Ikea furniture. . .
prev parent reply other threads:[~2015-11-12 16:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 10:23 [PATCH 8/8] ox-taskjuggler.el: allow trimming the task ID from its title Kosyrev Serge
2015-11-12 16:49 ` Rasmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb97jh83.fsf@gmx.us \
--to=rasmus@gmx.us \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).