From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps Date: Thu, 26 Nov 2015 11:21:24 +0100 Message-ID: <87vb8poycb.fsf@nicolasgoaziou.fr> References: <87ziy28ccw.fsf@nicolasgoaziou.fr> <87r3je8723.fsf@nicolasgoaziou.fr> <877fl5jhlt.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1teN-0004XC-7p for emacs-orgmode@gnu.org; Thu, 26 Nov 2015 05:19:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1teM-0004g9-G0 for emacs-orgmode@gnu.org; Thu, 26 Nov 2015 05:19:39 -0500 Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:55014) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1teM-0004g3-99 for emacs-orgmode@gnu.org; Thu, 26 Nov 2015 05:19:38 -0500 In-Reply-To: ("Gustav \=\?utf-8\?Q\?Wikstr\=C3\=B6m\=22's\?\= message of "Thu, 26 Nov 2015 10:01:07 +0000") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Gustav =?utf-8?Q?Wikstr=C3=B6m?= Cc: "sgeorgii ." , "emacs-orgmode@gnu.org" Gustav Wikstr=C3=B6m writes: > Ok, fair enough. A bit more difficult to follow the code now (in my > opinion) I honestly don't think so. Of course, YMMV. > but I guess it saves a few I/O's. If `setq' can be avoided (assuming a context of lexical binding) it's better, indeed. > There was a small error in your edit though. The push-statement feels > lonely outside of the let*. Duh. Fixed. Thank you. Regards,