emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug: Agenda: Invalid Function 4 [8.3.4 (release_8.3.4-702-gcd47ab @ ~/.emacs.d/packages/org-mode/lisp/)]
@ 2016-04-05 19:50 Ian Dunn
  2016-04-05 20:06 ` Nick Dokos
  2016-04-05 21:34 ` Nicolas Goaziou
  0 siblings, 2 replies; 3+ messages in thread
From: Ian Dunn @ 2016-04-05 19:50 UTC (permalink / raw)
  To: emacs-orgmode



Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------

        For some time now, I've been noticing that org-agenda-redo (the
'g' key in the Agenda buffer, since it isn't *exactly* the same) often
fails with the error "Invalid Function 4".  I looked into this, and
discovered that it only happened when I used a tag view list with only
TODO items.  A backtrace showed that the issue was the redo command, and
I believe I have solved the problem with the following patch:

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index e9f3505..2f7241b 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -4852,7 +4852,7 @@ The prefix arg TODO-ONLY limits the search to TODO entries."
       (setq org-agenda-query-string match)
       (setq org-agenda-redo-command
 	    (list 'org-tags-view
-		  org--matcher-tags-todo-only
+		  (list 'quote org--matcher-tags-todo-only)
 		  `(if current-prefix-arg nil ,org-agenda-query-string)))
       (setq files (org-agenda-files nil 'ifmode)
 	    rtnall nil)

If my patch doesn't work, I at least hope it helps everyone figure out
the real problem.

Thank you for your time.

-- 
Ian Dunn

Emacs  : GNU Emacs 25.1.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.14.13)
 of 2016-04-04
Package: Org-mode version 8.3.4 (release_8.3.4-702-gcd47ab @ ~/.emacs.d/packages/org-mode/lisp/)

current state:
==============
(setq
 org-tab-first-hook '(org-hide-block-toggle-maybe org-babel-hide-result-toggle-maybe
		      org-babel-header-arg-expand)
 org-speed-command-hook '(org-speed-command-default-hook org-babel-speed-command-hook)
 org-occur-hook '(org-first-headline-recenter)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-confirm-shell-link-function 'yes-or-no-p
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-babel-pre-tangle-hook '(save-buffer)
 org-mode-hook '(#[0 "\300\301\302\303\304$\207"
		   [org-add-hook change-major-mode-hook org-show-block-all append local] 5]
		 #[nil "\300\301\302\303\304$\207"
		   [org-add-hook change-major-mode-hook org-babel-show-result-all append local] 5]
		 org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point org-babel-execute-safely-maybe)
 org-directory "~/Documents/org"
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines
		  org-optimize-window-after-visibility-change)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 )

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: Bug: Agenda: Invalid Function 4 [8.3.4 (release_8.3.4-702-gcd47ab @ ~/.emacs.d/packages/org-mode/lisp/)]
  2016-04-05 19:50 Bug: Agenda: Invalid Function 4 [8.3.4 (release_8.3.4-702-gcd47ab @ ~/.emacs.d/packages/org-mode/lisp/)] Ian Dunn
@ 2016-04-05 20:06 ` Nick Dokos
  2016-04-05 21:34 ` Nicolas Goaziou
  1 sibling, 0 replies; 3+ messages in thread
From: Nick Dokos @ 2016-04-05 20:06 UTC (permalink / raw)
  To: emacs-orgmode

Ian Dunn <dunni@gnu.org> writes:

> Remember to cover the basics, that is, what you expected to happen and
> what in fact did happen.  You don't know how to make a good report?  See
>
>      http://orgmode.org/manual/Feedback.html#Feedback
>
> Your bug report will be posted to the Org-mode mailing list.
> ------------------------------------------------------------------------
>
>         For some time now, I've been noticing that org-agenda-redo (the
> 'g' key in the Agenda buffer, since it isn't *exactly* the same) often
> fails with the error "Invalid Function 4".  I looked into this, and
> discovered that it only happened when I used a tag view list with only
> TODO items.  A backtrace showed that the issue was the redo command, and
> I believe I have solved the problem with the following patch:
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index e9f3505..2f7241b 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -4852,7 +4852,7 @@ The prefix arg TODO-ONLY limits the search to TODO entries."
>        (setq org-agenda-query-string match)
>        (setq org-agenda-redo-command
>  	    (list 'org-tags-view
> -		  org--matcher-tags-todo-only
> +		  (list 'quote org--matcher-tags-todo-only)
>  		  `(if current-prefix-arg nil ,org-agenda-query-string)))
>        (setq files (org-agenda-files nil 'ifmode)
>  	    rtnall nil)
>
> If my patch doesn't work, I at least hope it helps everyone figure out
> the real problem.
>
> Thank you for your time.

I don't know if the patch is good (it probably is), but the *real*
problem is what's shown by that backtrace you mentioned, so you should
include the backtrace in your bug report (at least in the future).

--
Nick

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Bug: Agenda: Invalid Function 4 [8.3.4 (release_8.3.4-702-gcd47ab @ ~/.emacs.d/packages/org-mode/lisp/)]
  2016-04-05 19:50 Bug: Agenda: Invalid Function 4 [8.3.4 (release_8.3.4-702-gcd47ab @ ~/.emacs.d/packages/org-mode/lisp/)] Ian Dunn
  2016-04-05 20:06 ` Nick Dokos
@ 2016-04-05 21:34 ` Nicolas Goaziou
  1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Goaziou @ 2016-04-05 21:34 UTC (permalink / raw)
  To: Ian Dunn; +Cc: emacs-orgmode

Hello,

Ian Dunn <dunni@gnu.org> writes:

>        (setq org-agenda-query-string match)
>        (setq org-agenda-redo-command
>  	    (list 'org-tags-view
> -		  org--matcher-tags-todo-only
> +		  (list 'quote org--matcher-tags-todo-only)
>  		  `(if current-prefix-arg nil ,org-agenda-query-string)))
>        (setq files (org-agenda-files nil 'ifmode)
>  	    rtnall nil)
>
> If my patch doesn't work, I at least hope it helps everyone figure out
> the real problem.

Thank you. I applied it with a slight change (using backquote syntax).

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-04-05 21:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-05 19:50 Bug: Agenda: Invalid Function 4 [8.3.4 (release_8.3.4-702-gcd47ab @ ~/.emacs.d/packages/org-mode/lisp/)] Ian Dunn
2016-04-05 20:06 ` Nick Dokos
2016-04-05 21:34 ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).