From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] expose nrepl's timeout setting in ob-clojure.el
Date: Sun, 10 Apr 2016 10:20:22 +0200
Message-ID: <87vb3pnad5.fsf@nicolasgoaziou.fr>
References: <56FABD8E.2000705@fgiasson.com> <87twjfcbt6.fsf@nicolasgoaziou.fr>
	<570521D3.4030009@fgiasson.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37036)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1apAZT-0003sS-CK
	for emacs-orgmode@gnu.org; Sun, 10 Apr 2016 04:18:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1apAZQ-0000Sm-6H
	for emacs-orgmode@gnu.org; Sun, 10 Apr 2016 04:18:15 -0400
Received: from relay3-d.mail.gandi.net ([217.70.183.195]:36343)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1apAZP-0000Si-Vv
	for emacs-orgmode@gnu.org; Sun, 10 Apr 2016 04:18:12 -0400
In-Reply-To: <570521D3.4030009@fgiasson.com> (Frederick Giasson's message of
	"Wed, 6 Apr 2016 10:48:51 -0400")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Frederick Giasson <fred@fgiasson.com>
Cc: emacs-orgmode@gnu.org

Hello,

Thank you for the update.

Frederick Giasson <fred@fgiasson.com> writes:

> +(defcustom org-babel-clojure-sync-nrepl-timeout 10
> +  "Timeout value, in seconds, of a Clojure sync call. 
> +   If the value is nil, timeout is disabled."
> +  :type 'integer
> +  :group 'org-babel)

Some keywords are missing:

  :version "25.1"
  :package-version '(Org . "9.0")

and perhaps

  :safe #'wholenump

>  (defcustom org-babel-clojure-backend
>    (cond ((featurep 'cider) 'cider)
>  	(t 'slime))
> @@ -94,8 +100,9 @@
>         (let ((result-params (cdr (assoc :result-params params))))
>  	 (setq result
>  	       (nrepl-dict-get
> -		(nrepl-sync-request:eval
> -		 expanded (cider-current-connection) (cider-current-session))
> +		(let ((nrepl-sync-request-timeout org-babel-clojure-sync-nrepl-timeout))
> +		  (nrepl-sync-request:eval
> +		   expanded (cider-current-connection) (cider-current-session)))

You forgot to

(defvar nrepl-sync-request-timeout)

I also think it makes sense to merge the 3 patches.

Regards,

-- 
Nicolas Goaziou