From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Error handling in org-make-link-string Date: Sat, 14 Apr 2018 19:32:36 +0200 Message-ID: <87vactn16z.fsf@nicolasgoaziou.fr> References: <87o9imh5mv.fsf@bobnewell.net> <87sh7ynd0i.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60820) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7P2Y-0004BI-Nx for emacs-orgmode@gnu.org; Sat, 14 Apr 2018 13:32:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f7P2V-000454-Ff for emacs-orgmode@gnu.org; Sat, 14 Apr 2018 13:32:42 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:47047) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f7P2V-000440-9H for emacs-orgmode@gnu.org; Sat, 14 Apr 2018 13:32:39 -0400 In-Reply-To: (Bob Newell's message of "Sat, 14 Apr 2018 06:54:23 -1000") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Bob Newell Cc: emacs-orgmode@gnu.org Hello, Bob Newell writes: > Aloha, > > Either of your suggested solutions would work, of course, and limit > effects to org-xxx-copy-for-org-mode. I didn't go that way because I > didn't want to have to continually modify the core product on my own > :) > > The idea of > > (if (org-string-nw-p link-location > > etc. may be best because we can have a guaranteed nil on a bad link, > rather than ignore-errors which (I think?) may have a different > return. I didn't put an error message in my 'advice' workaround but it > would be a good idea. Done. Thank you. Regards, -- Nicolas Goaziou