From mboxrd@z Thu Jan 1 00:00:00 1970 From: Karl Fogel Subject: Re: [PATCH] Use prefix arg to control scope of org-narrow-to-subtree. Date: Mon, 02 Dec 2019 13:17:59 -0600 Message-ID: <87v9qysfiw.fsf@red-bean.com> References: <87ftq7kyvt.fsf@red-bean.com> <878svyqxwc.fsf@nicolasgoaziou.fr> <87y2vwv3gm.fsf_-_@red-bean.com> <84immy4v3r.fsf@gmail.com> <87sgm2txeb.fsf@red-bean.com> <84k17elfnu.fsf@gmail.com> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:38734) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibrCt-0001Md-JZ for emacs-orgmode@gnu.org; Mon, 02 Dec 2019 14:18:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibrCs-0007xe-GS for emacs-orgmode@gnu.org; Mon, 02 Dec 2019 14:18:03 -0500 Received: from mail-yw1-xc43.google.com ([2607:f8b0:4864:20::c43]:35209) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ibrCs-0007x9-A1 for emacs-orgmode@gnu.org; Mon, 02 Dec 2019 14:18:02 -0500 Received: by mail-yw1-xc43.google.com with SMTP id i190so252327ywc.2 for ; Mon, 02 Dec 2019 11:18:02 -0800 (PST) In-Reply-To: <84k17elfnu.fsf@gmail.com> (Marco Wahl's message of "Mon, 02 Dec 2019 19:56:53 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Org-mode Cc: Marco Wahl On 02 Dec 2019, Marco Wahl wrote: >Karl Fogel writes: >> Since `widen' itself is already available via C-x n w, it might be >> better to save a special flag value like that for some special >> behavior that we (or someone else) might think of in the future. I'm >> pretty sure that anyone using `org-narrow-to-subtree' must also know >> about the `widen' command, too. > >Okay, this sounds sound. > >Let me be a bit more explicit about my wish: I vote for the prefix arg 0 >to widen because this fits to the logic to view the whole file as level >0 subtree. With this perspective on the feature the effect of a numeric >prefix argument is clear as day: > >... >C-u 2 M-x org-narrow... => Narrow to the level-2 subtree containing point. >C-u 1 M-x org-narrow... => Narrow to the level-1 subtree containing point. >C-u 0 M-x org-narrow... => Narrow to the level-0 subtree containing point. > >The last line stands in opposition to the current behavior. > >C-u 0 M-x org-narrow... => Narrow to the level-1 subtree containing point. > ^ ^ Oh, yes, I get the logic, from a consistency standpoint. My only concern is that a) it's unnecessary, because `widen' is available, and b) some day we might think of a better special meaning for C-u 0 (and in the meantime it could error instead of narrowing to the current level-1 subtree). But I don't feel strongly about it either way. Perhaps consistency is desirable here, although I tend to think that consistency is overrated in UI/UX in general -- the famous example of "`transpose-chars' at the end of a line" comes to mind. Hmm, but on the other hand, your proposed consistency *would* be good if anyone's ever calling `org-narrow-to-subtree' from Lisp with an algorithmically calculated STEPS argument. I can't imagine what kind of circumstance that would be, but if it's a general principle of Org Mode to consider "level 0" to be the entire buffer, then we should probably go with your proposed behavior. So I guess I'm tentatively +1... Does anyone else have any thoughts on this? Best regards, -Karl