From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: tbanelwebmin <tbanelwebmin@free.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: [ANN] faster org-table-to-lisp
Date: Fri, 01 May 2020 12:15:22 +0200 [thread overview]
Message-ID: <87v9lg7yh1.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <9944ffa3-5e1f-56f2-c337-302b59d204f6@free.fr> (tbanelwebmin@free.fr's message of "Fri, 1 May 2020 08:35:11 +0200")
Hello,
tbanelwebmin <tbanelwebmin@free.fr> writes:
> Nicolas, how did you do that? Your version is 25% faster than mine,
> and the code is 33% shorter! Very elegant.
Thank you. There's nothing fancy, really.
The main difference is that it does not call `org-table-end'. Minor
tweaks are:
- use simpler regexps,
- call `skip-chars-forward' whenever possible.
> Sorry, I may not understood what you said:
> = Since you're changing the signature, I suggest to provide the table
> = element instead of ORG-AT-TABLE-P. AFAICT, `org-babel-read-element',
> = through `org-babel-read-table', would greatly benefit from this.
>
> Could you elaborate (if still relevant)?
If you know the table ELEMENT, you don't need to check if you're at
a table, nor do you need to compute table boundaries. We could have made
use of this information to avoid a call to `org-at-table-p', much like
your initial intent.
Thinking about it, we don't even need to call `org-at-table-p' at all.
Indeed, this is a low-level, non-interactive, function. We can
reasonably expect the callers to check if they are really at a table in
the first place.
It would increase speed for this function noticeably, and the ELEMENT
argument would not be relevant anymore.
WDYT?
> The side effect of `re-search-forward' was to advance point, while
> `looking-at' don't move.
Ah true. I overlooked that.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-05-01 10:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 6:34 [ANN] faster org-table-to-lisp tbanelwebmin
2020-04-30 8:09 ` Nicolas Goaziou
2020-04-30 20:28 ` tbanelwebmin
2020-04-30 20:47 ` Daniele Nicolodi
2020-04-30 21:01 ` tbanelwebmin
2020-04-30 22:35 ` Nicolas Goaziou
2020-05-01 6:35 ` tbanelwebmin
2020-05-01 10:15 ` Nicolas Goaziou [this message]
2020-05-01 12:41 ` tbanelwebmin
2020-05-01 13:11 ` Nicolas Goaziou
2020-05-02 7:41 ` tbanelwebmin
2020-05-02 9:35 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9lg7yh1.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=tbanelwebmin@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).