From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: tbanelwebmin <tbanelwebmin@free.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] faster org-table-align
Date: Fri, 08 May 2020 15:44:28 +0200 [thread overview]
Message-ID: <87v9l65yo3.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <00ea3013-c768-cdd9-3385-980bba796460@free.fr> (tbanelwebmin@free.fr's message of "Fri, 8 May 2020 14:50:44 +0200")
Hello,
tbanelwebmin <tbanelwebmin@free.fr> writes:
> `org-table-align' may benefit from recent `org-table-to-lisp'
> speed-up.
>
> The current code contains the following lines in org-table.el. They
> parse the table into a Lisp structure, which is precisely what
> `org-table-to-lisp' is supposed to do.
>
> (fields (mapcar
> (lambda (l)
> (and (not (string-match-p org-table-hline-regexp l))
> (org-split-string l "[ \t]*|[ \t]*")))
> (split-string (buffer-substring beg end) "\n" t)))
>
> Just replace them by a call to `org-table-to-lisp':
>
> (fields (cl-loop for row in (org-table-to-lisp)
> collect (and (listp row) row)))
Good catch! I applied a similar change in master. Let me know how it
goes.
Thank you!
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-05-08 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 12:50 [PATCH] faster org-table-align tbanelwebmin
2020-05-08 13:44 ` Nicolas Goaziou [this message]
2020-05-08 14:56 ` tbanelwebmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9l65yo3.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=tbanelwebmin@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).