From: Kyle Meyer <kyle@kyleam.com>
To: Kaushal Modi <kaushal.modi@gmail.com>,
emacs-org list <emacs-orgmode@gnu.org>
Subject: Re: `#+author:' stopped setting the author to empty string
Date: Mon, 18 May 2020 23:30:43 +0000 [thread overview]
Message-ID: <87v9ksstwc.fsf@kyleam.com> (raw)
In-Reply-To: <CAFyQvY2ZGJPv=Ajx2_1xR0otv=VQYHcrUwzS46PmnyJ2Co1KVg@mail.gmail.com>
Kaushal Modi writes:
> At some point in the past month or so, I have noticed that on Org master,
> #+author: does not set the author to empty in the exports.
>
> Simply example to reproduce:
Thanks for the minimal example.
> I looked through the commits on master in the past month, but I don't see
> any author-specific change that would affect *all* the exporter backends.
It bisects to b4e91b7e9 (New function: org-collect-keywords,
2020-04-26). I haven't done much digging, but I was able to restore the
behavior with the change below, which may be a bad idea for other
reasons.
diff --git a/lisp/org.el b/lisp/org.el
index 0e1e05239..a8db4c2bf 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -4501,7 +4501,6 @@ (defun org--collect-keywords-1 (keywords uniques files alist)
(push (cons key value) alist)
(setq keywords (remove key keywords))
(setq regexp (org-make-options-regexp keywords)))
- ((not (org-string-nw-p value)) nil)
((null entry) (push (list key value) alist))
(t (push value (cdr entry)))))))))))
alist)))
next prev parent reply other threads:[~2020-05-18 23:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 13:57 `#+author:' stopped setting the author to empty string Kaushal Modi
2020-05-18 14:30 ` Julius Müller
2020-05-18 23:30 ` Kyle Meyer [this message]
2020-05-19 8:04 ` Nicolas Goaziou
2020-05-20 0:38 ` Kyle Meyer
2020-05-20 14:08 ` Kaushal Modi
2020-05-19 15:08 ` Kaushal Modi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9ksstwc.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=emacs-orgmode@gnu.org \
--cc=kaushal.modi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).