From: Gustavo Barros <email@example.com> To: Bastien <firstname.lastname@example.org> Cc: Marco Wahl <email@example.com>, firstname.lastname@example.org Subject: Re: Bug: Org line commands and visual-line mode bindings [9.3.7 (9.3.7-15-gc9abb4-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200727/)] Date: Tue, 22 Dec 2020 17:18:21 -0300 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> Hi Bastien, Hi Marco, On Fri, 04 Sep 2020 at 14:37, Bastien <email@example.com> wrote: > Hi Gustavo, > > Gustavo Barros <firstname.lastname@example.org> writes: > >> I do think my other workaround is worth pondering to be included, so >> that this would work out-of-the-box. Do you see any particular >> drawbacks of setting these bindings directly (that is, not by >> remapping) >> in `org-mode-map'? > > You mean by adding something like > > (org-defkey org-mode-map (kbd "C-a") #'org-beginning-of-line) > > in org-keys.el? I'm pretty sure such "hard" remapping breaks an Emacs > convention--I'll ask emacs-devel, because that would indeed fix the > problem you are reporting. > > Thanks for insisting, I've been playing with 'mwim.el' today, and came up with something that might be interesting. Btw, Bastien, I've seen the message you've sent to emacs-devel about this. Thank you. A pity it doesn't seem to have drawn much attention. Anyway, what I came up is a slight variation from Marco's approach, which may be just general enough to be employed by Org. #+begin_src emacs-lisp (add-hook 'visual-line-mode-hook #'my/visual-line-mode-hook-for-org) (defun my/visual-line-mode-hook-for-org () (when (and (derived-mode-p 'org-mode) visual-line-mode) ;; Ensure 'visual-line-mode' does not shadow Org's line commands. (local-set-key [remap move-beginning-of-line] nil) (local-set-key [remap move-end-of-line] nil) (local-set-key [remap kill-line] nil))) #+end_src I've lightly tested this here and it seems to be working. WDYT? Best regards, Gustavo.
next prev parent reply other threads:[~2020-12-22 20:18 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-28 1:18 Gustavo Barros 2020-07-28 15:34 ` Marco Wahl 2020-07-28 16:38 ` Gustavo Barros 2020-09-04 15:20 ` Bastien 2020-09-04 15:44 ` Gustavo Barros 2020-09-04 17:37 ` Bastien 2020-09-04 18:24 ` Gustavo Barros 2020-12-22 20:18 ` Gustavo Barros [this message] 2020-12-22 20:24 ` Gustavo Barros 2020-12-22 21:28 ` Gustavo Barros 2021-05-01 20:28 ` Bastien 2021-05-01 20:50 ` Gustavo Barros
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: Bug: Org line commands and visual-line mode bindings [9.3.7 (9.3.7-15-gc9abb4-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200727/)]' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).