From: Timothy <tecosaur@gmail.com>
To: Jens Lechtenboerger <lechten@wi.uni-muenster.de>
Cc: Kyle Meyer <kyle@kyleam.com>, org-mode-email <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] tweaks to ox-html style
Date: Sat, 13 Feb 2021 02:16:05 +0800 [thread overview]
Message-ID: <87v9axqh7v.fsf@gmail.com> (raw)
In-Reply-To: <87wnvd2ph3.fsf@wi.uni-muenster.de>
Jens Lechtenboerger <lechten@wi.uni-muenster.de> writes:
> I do not know why the CDATA lines exist. I don’t see a reason to
> keep them (patch 0001), but that might be a lack of understanding on
> my part.
I'll cover this in my reply to your follow-up.
> Patch 0003 is about whitespace fixes.
>
> Patches 0002, 0004, 0005 change defconst styling. I don’t have a
> strong opinion here. However, if they are changed now, what about
> turning them into defcustoms? Then each of us would be entitled to
> their own opinion ;)
>
> The docstring for org-html-head-include-default-style says that
> org-html-style-default (a defconst proposed to be changed here)
> should not be changed. Why not?
The defconst is left a defsconst because I don't really know why it is
one, and when I don't know why something is the way it is, I try to leave
it alone. In my own config I actually overwrite it, but oh well.
I'm guessing this is just a case of "User beware, this contains
important stuff to have Org look reasonable. Don't remove that."
Perhaps this should be a defcustom? It would be good to hear from
someone else on this. If this ends up being a hold up though I'd rather
resolve this separately.
--
Timothy.
next prev parent reply other threads:[~2021-02-12 18:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 10:46 [PATCH] TEC
2021-01-20 11:00 ` [PATCH] tweaks to ox-html style TEC
2021-02-12 6:16 ` Kyle Meyer
2021-02-12 16:57 ` Jens Lechtenboerger
2021-02-12 17:08 ` Jens Lechtenboerger
2021-02-12 18:22 ` Timothy
2021-02-13 14:43 ` Jens Lechtenboerger
2021-02-12 18:16 ` Timothy [this message]
2021-02-12 21:46 ` Tim Cross
2021-02-13 9:28 ` Eric S Fraga
2021-02-13 13:32 ` Christian Moe
2021-02-14 4:36 ` Timothy
2021-04-28 3:38 ` [PATCH] Bastien
2021-04-28 3:53 ` [PATCH] Timothy
2021-04-28 6:36 ` [PATCH] Bastien
2021-04-28 6:33 ` [PATCH] Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9axqh7v.fsf@gmail.com \
--to=tecosaur@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=kyle@kyleam.com \
--cc=lechten@wi.uni-muenster.de \
--subject='Re: [PATCH] tweaks to ox-html style' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).