From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qNfMNQenpmA4SQEAgWs5BA (envelope-from ) for ; Thu, 20 May 2021 20:14:31 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id SD6YMQenpmDlLwAAB5/wlQ (envelope-from ) for ; Thu, 20 May 2021 18:14:31 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4914E28056 for ; Thu, 20 May 2021 20:14:31 +0200 (CEST) Received: from localhost ([::1]:55236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljnBl-0000Ag-Vq for larch@yhetil.org; Thu, 20 May 2021 14:14:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljn3f-0000Uu-I4 for emacs-orgmode@gnu.org; Thu, 20 May 2021 14:06:09 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:36581) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljn3b-000519-B3 for emacs-orgmode@gnu.org; Thu, 20 May 2021 14:06:07 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 44CA160004; Thu, 20 May 2021 18:06:01 +0000 (UTC) From: Nicolas Goaziou To: Maxim Nikulin Subject: Re: [Patch] tests for org-remove-invisible References: <87a6qg1rjx.fsf@posteo.net> <874kgft7n1.fsf@nicolasgoaziou.fr> <87blanxb1z.fsf@posteo.net> <87lf9fa3ak.fsf@posteo.net> <87sg3n8f33.fsf@posteo.net> <87tuo2d670.fsf@nicolasgoaziou.fr> <87r1j6b6ku.fsf@nicolasgoaziou.fr> <87a6pt9hyd.fsf@nicolasgoaziou.fr> <874kg0ae0k.fsf@nicolasgoaziou.fr> Mail-Followup-To: Maxim Nikulin , emacs-orgmode@gnu.org Date: Thu, 20 May 2021 20:06:00 +0200 In-Reply-To: (Maxim Nikulin's message of "Fri, 21 May 2021 00:06:01 +0700") Message-ID: <87v97dz3ef.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.195; envelope-from=mail@nicolasgoaziou.fr; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621534471; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=0+uS4mFXx3oPCej2vEevDGnU/EgQYuvWm0BnS0IRTF4=; b=Dp57sANZehZtpwMPe3jGPzqHVic2RY/RoeVZx5oNjdrf39yFleRLlr5tvF7XEH0z4abrNT uTLzAbueJtDKF32C0vccBQVH6SQ+yozmk0dkoOcofeHilM+v2FsYi+u/xIfs4EVdXtZ4Cl LmzI7W/t6zQRZstykNzQ2cM82Wduui3i8QASuDoMqxJP/WCxqskXiR0uvjzPEILRKlOsNE KgoMZyyOIXEnaV46BM0ug1Pn9++RXrDl01Myjl6o/7VEZF2q6Wj/8XnRSB8utW9LbJLr4J WTqNFaME4caF0tt7qtMbN2epENw0M+yDnPIyCsXHsvV1hAgSMt1dhFLwnmqWBA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621534471; a=rsa-sha256; cv=none; b=RbnI0GnWQaNWPU59clGnZy7OoVJbGigAaveptgkgHJJw96bAdgO5dmLcNOmTZU/nMjz6WD WHm9f2R7UqeeoksXczJRoXJlf8SxJWPCFnyXZes0997g6dbr7izxFQ64RcakpRFwsqYYvM 2i3wJRmT4tUd+Bnbo7GwUWlRSBHjBRFfv+zkPyOtWLHSqqE0rWWP5Hcxbnrg+x/M479V+9 T66wRfBQbySYZ45C2RNVW1s8rZL5xBgCtJaZJZe/TA3/jpUKe71Aj5asb2htm1W3yMx6Qu YYBMBssURUhPT/xU3aacq4gzOEV/hhEn0Hih4h3XY/q6uqbqpbgYlAZEGIqZVw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.44 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 4914E28056 X-Spam-Score: -2.44 X-Migadu-Scanner: scn0.migadu.com X-TUID: 0Jg/WeMIVB4q Hello, Maxim Nikulin writes: > The main patch that fixes org-remove-invisible to improve list sorting is landed. > > Let me remind that there were patches that added more test cases: > https://orgmode.org/list/s5p88r$go9$1@ciao.gmane.io > Is there any interest in them? > > In the following subthread Nicolas mentioned that some of them could fail > https://orgmode.org/list/87r1j6b6ku.fsf@nicolasgoaziou.fr > I do not see any reason for failure. I just have tried C.UTF-8, en_US.UTF-8, > es_ES.UTF-8, and ru_RU.UTF-8 locales (interactively) and do not see any > problem. This set of locales has 3 different collation rules, > however I do not think it matters for tests. [...] >> There is redefinition of `string-collate-lessp' to run tests with "C" locale: >> https://code.orgmode.org/bzg/org-mode/src/master/testing/lisp/test-org-list.el#L1207 I probably missed that re-definition. Feel free to disregard my comment. Regards, -- Nicolas Goaziou