From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qJv6L2JmbGEJOgAAgWs5BA (envelope-from ) for ; Sun, 17 Oct 2021 20:07:30 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id AIlzK2JmbGGlEAAAbx9fmQ (envelope-from ) for ; Sun, 17 Oct 2021 18:07:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 476F67FEE for ; Sun, 17 Oct 2021 20:07:30 +0200 (CEST) Received: from localhost ([::1]:54114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcAZE-0004N2-Nh for larch@yhetil.org; Sun, 17 Oct 2021 14:07:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcAYc-0004Mt-8q for emacs-orgmode@gnu.org; Sun, 17 Oct 2021 14:06:50 -0400 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:42946) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mcAYa-0005jA-88 for emacs-orgmode@gnu.org; Sun, 17 Oct 2021 14:06:49 -0400 Received: by mail-pl1-x62e.google.com with SMTP id l6so9688076plh.9 for ; Sun, 17 Oct 2021 11:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:user-agent:from:to:subject:date:in-reply-to:message-id :mime-version; bh=4hMvjKk+VHyfO7wkuUZ0xJ29UUPgToTkQ/5DNScSilg=; b=hqXcg+nGNjVCT6DZz3Zx7CofFlKED/nv3YuhTzUJTV9pWPQ76+11vgmGipaL5sLq6L WHG5sW1JX5o1CVdXI9aeeGjW4HAARVomaIPeW5WzhHfMiBC3SPvGwkXbHxOO65jxpubS ozhB7GQFe2QzjGH6lk1c9J+zMU/wfauhL6HqJWvVmIlxov1zYkcGqqA6rxSbvb5nojOc 8pAwAIKAt7F07uS1c9zreeBYOCI+Hzwichv41O7MRNp/TaotxHfZingiF0BxWz8Ep0n5 kEDPF0dySMRXMqaN44jXmRr2gAbTdqldYUZSqBFbqlD4PBDihgllpPvmQglUVfGDQtO2 Ftfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:subject:date :in-reply-to:message-id:mime-version; bh=4hMvjKk+VHyfO7wkuUZ0xJ29UUPgToTkQ/5DNScSilg=; b=W5/oVjWKb7u4jhvIHL+9Ys+ECUaBu4Kx20CHpqCSBC2pPWhMIGxzxJ2ALCokpzyOoV LOmVeK2DjhPd+P68zpULOYdKuvgKcgywCqH+VssvHt3pTgTekq59DlrBYeKw5eSX58Ox fj/QW9/Nvfc6QHOFajvpzfb9hi4SKs2lto915vRerU0+Vk0/Fxe3Q1Z9yuw6/RCiuG+H KkiUYVnxu8xRflEvMWFeN82ff4CAMXXhWpWjv1fVt+9SjM6PiW0iIV22Q1nu6ktyN0od 3Dg9D3iOQYkH9kf1UgOt0DQRKSEW50Kzs4dwRXKr3h12RzZ26gdKW0GbXI7dpfUh3kSK ZxrQ== X-Gm-Message-State: AOAM531xBtcM/GDK02sZzaYrLiLDyMYjQAgNcStjuGUBJP8323FimiaQ 7JhW4TMqKnf3THgbfNsh26p0YqGbfmc= X-Google-Smtp-Source: ABdhPJyR3rQqNES/R7+7Xvd44ng+UFxoWdFRsZQyLls3As9Q3rBZvCmQqS7kZAwnQB35tuHeeSAsYg== X-Received: by 2002:a17:902:e848:b0:13e:f908:155a with SMTP id t8-20020a170902e84800b0013ef908155amr23215629plg.13.1634494006123; Sun, 17 Oct 2021 11:06:46 -0700 (PDT) Received: from tim-desktop ([124.149.106.234]) by smtp.gmail.com with ESMTPSA id q35sm17084054pjk.41.2021.10.17.11.06.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Oct 2021 11:06:45 -0700 (PDT) References: <875ytvvigc.fsf@localhost> User-agent: mu4e 1.7.0; emacs 28.0.60 From: Tim Cross To: emacs-orgmode@gnu.org Subject: Re: [BUG] org-toggle-headline inserts "TODO" regardless of local definitions [9.5 (9.5-g0a86ad @ /home/rasmus/.emacs.d/elpa/org-9.5/)] Date: Mon, 18 Oct 2021 04:53:01 +1100 In-reply-to: <875ytvvigc.fsf@localhost> Message-ID: <87v91vle4u.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=theophilusx@gmail.com; helo=mail-pl1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634494050; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4hMvjKk+VHyfO7wkuUZ0xJ29UUPgToTkQ/5DNScSilg=; b=rm9BADxu90LtUFeisV5HgHVynf/QXRfsWuxobg+zqFj+IT04GyBKwNjbQRy4YzahVAXw+j 3QsNI2R4pvXmLPlPsRmThAhaw66QrE2YyZG1F+LO8r64ouU3Mp6Hl+I9eRmv/RCHl+FkI7 W+cu1861XGK9uA0/xisLgSEXAfzPg0F6E4Vz/r5tKCBkkV+B6vvuralnhTaAlHUHY7bbLq 7TuGDOjgsATmFRp2Av7Z9DCMEbcDxdSMdKrDQYLfLWhsbTU6HAmFk+EuDMMeFJn4UHLCF+ +KZAyoZeDdcwGq5u4hdntQ93oVG0L4gdRiaj9DDBXlFVSXTXMLzg+WZRaYllnA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634494050; a=rsa-sha256; cv=none; b=V5CFm4sysa5KVUb/TY+RNa3jLLKRe1SYnA4jKJZWMwEFgKuBt6xog4GO8kcHOttmZ5Hb3l nzmjyUIECscDkxfHFU32gxtOGSYexY+ivyZfGCaBFrjmxW+M7Et0ZSse4F85gV7/ps4BDQ r89vu3dyynZM9tcJVl6h7gE2Zn6uUQ7szJBzPcZ6iBB5cXDj9Q8Gpn1RDg06v01HKplNw/ zo4KI5stEyGH4ego4krgmaOj2BAjdgLY/fllBL7umNryuMdBHxWhu1ZR01CDoUnuiFOeSZ LEKPJ/pJjX4vUsORkXMZxGjcztNECK0MyDd9BDBwnDjhKkdSF2bSFWkU+2mzzw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=hqXcg+nG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.52 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=hqXcg+nG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 476F67FEE X-Spam-Score: -2.52 X-Migadu-Scanner: scn1.migadu.com X-TUID: +T3sb7acWVEu Ihor Radchenko writes: > autofrettage writes: > >> * DONE Apple >> ** TODO Banana >> >> ...instead of these: >> >> * baz Apple >> ** foo Banana > > Confirmed. > > Currently, checkbox to todo keyword mapping is hard-coded in > org-list-to-subtree. > > We may use something like > [ ] -> (car org-not-done-keywords); > [-] -> (car org-not-done-keywords); > [X] -> (car org-done-keywords); > I would agree hard coded todo keywords is an issue given we allow people to define the set of todo keywords. I think your suggestion to use the car of 'org-not-done-keywords and 'org-done-keywords is an improvement (even if not perfect). I do wonder if the doc string for org-toggle-heading needs updating. It makes no reference to making a list item a todo heading if it looks like a todo item. I was actually surprised that org-toggle-heading adds keywords at all. While headings and todo items are certainly related, my expectation would be that a function called org-toggle-heding would do just that - add stars if none exist and remove them if they do. I would not necessarily expect a list item to be converted to a todo heading, only a heading.