From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AKtVNj0UrmE6ugAAgWs5BA (envelope-from ) for ; Mon, 06 Dec 2021 14:46:37 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 6JodMj0UrmF9PwAA1q6Kng (envelope-from ) for ; Mon, 06 Dec 2021 13:46:37 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6B74B13700 for ; Mon, 6 Dec 2021 14:46:37 +0100 (CET) Received: from localhost ([::1]:52252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1muEKC-0000FQ-IV for larch@yhetil.org; Mon, 06 Dec 2021 08:46:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muDsU-00076H-Tv for emacs-orgmode@gnu.org; Mon, 06 Dec 2021 08:17:58 -0500 Received: from [2001:7c0:300c:3105::8602:5d6] (port=55800 helo=mx04.uni-tuebingen.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muDsS-0006Oe-Gl for emacs-orgmode@gnu.org; Mon, 06 Dec 2021 08:17:58 -0500 Received: from auth2-smtp.messagingengine.com (auth2-smtp.messagingengine.com [66.111.4.228]) by mx04.uni-tuebingen.de (Postfix) with ESMTPSA id 353DB20A0EF3; Mon, 6 Dec 2021 14:17:45 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id ACF5C27C005B; Mon, 6 Dec 2021 08:17:40 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 06 Dec 2021 08:17:40 -0500 X-ME-Sender: X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrjeefgdehtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffffkgggtsehttddttddttddtnecuhfhrohhmpeftihgthhgrrhgu ucfnrgifrhgvnhgtvgcuoehrihgthhgrrhgurdhlrgifrhgvnhgtvgesuhhnihdqthhuvg gsihhnghgvnhdruggvqeenucggtffrrghtthgvrhhnpeeghfeuudetheejgfffveevhfev gfdvffeghefgudehvdeludduuddtvdehjefhteenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehrfihlodhmvghsmhhtphgruhhthhhpvghrshho nhgrlhhithihqdduudejkeegheduvdekqdduledtvdejleeggedqrhhitghhrghrugdrlh grfihrvghntggvpeepuhhnihdqthhuvggsihhnghgvnhdruggvsehfrghsthhmrghilhdr tghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Dec 2021 08:17:40 -0500 (EST) Received: from rwl by aquinas with local (Exim 4.92) (envelope-from ) id 1muDsA-0008Tw-G0; Mon, 06 Dec 2021 14:17:38 +0100 From: Richard Lawrence To: Kaushal Modi , Tim Cross Subject: Re: [PATCH] Fix org-comment-line-break-function In-Reply-To: References: <87lf18fue9.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87v90cpcdx.fsf@yandex.com> <87ilwcf31l.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87pmqjkai3.fsf@gmail.com> <87fsrffknl.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87czmijtrp.fsf@gmail.com> <87o861o9sh.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87h7btpfbt.fsf@gmail.com> <87zgpli5nc.fsf@gmail.com> <871r2suhw2.fsf@gmail.com> Date: Mon, 06 Dec 2021 14:17:38 +0100 Message-ID: <87v901oost.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:7c0:300c:3105::8602:5d6 (failed) Received-SPF: pass client-ip=2001:7c0:300c:3105::8602:5d6; envelope-from=richard.lawrence@uni-tuebingen.de; helo=mx04.uni-tuebingen.de X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marco Wahl , emacs-org list , Nicolas Goaziou Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638798397; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=IOQPlVIOHPCB2y85uZJIZ3uenmUHFZ2ygawROsh4mdc=; b=NdFHsAS7vWSg2w/8BSY+D9FbrRQxVdxxNPsRo5CTtBgEiuGcCCZAAsSuoUllhGQWRF9VpX tAp6nzro5Am7P3cwCartpeb3bdZD3h6f8dT8SJlDvhDRuMrd2FL0KbwC2Ii2E1FyW4aEYE iKNl9GCVn29bI1dwmwbOVT+SJt5ep7qHJ8HCFleVZki0UDnjZfaLaPEgNpW8w3xeyJm2+l hWfoRqn431iZgsQygNF3QZQId+Wruc9eMB3MFnU80PriOvbaPfIkqx2GUU2dAckcJGOwWb p/I4EY8dC5IoxARgjLVeqMNdRit3yoatxY5cVN5uI0Ymj+QbsAn+HZTQ2f7xnw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638798397; a=rsa-sha256; cv=none; b=fozTit973KBUodTIpZt3OMec1sTGx0zIHreLT7O1oTltmHk2Vd+KLmWbXy+9RI9u5DrspA JZVI6lNH+jkA1JguDNLn3B/Smmhapv0C3KUMKFMqz/EO6M+Q6IOFdstABqCsXwYVtzfSw2 fQkOjvk2+fh5bWyMVXiOAGgWq01XmVEDSUd+CQ2M6PSfC1Qj2J7Z1i0u+6Kg7MV01O2Ubd TjKqc/vwphIErat3zxFUOCWDcF4xOnkLjNPAa04KcjpEHxbrfKGmKKlIBd2pdGy8JK7egX c9FVNShIuqebuqdyyPhF2ZwhP7yH2FnsTT7SAK5zCWHvDYi5x7VV7y4BBTFCfA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=uni-tuebingen.de (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 0.06 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=uni-tuebingen.de (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6B74B13700 X-Spam-Score: 0.06 X-Migadu-Scanner: scn0.migadu.com X-TUID: iudGnM1uCk17 Kaushal Modi writes: > On Sat, Dec 4, 2021, 5:25 PM Tim Cross wrote: > >> Given that Nicholas cannot remember the reason for the original function >> and suspects it was meant to be an internal only function, I think this >> patch is probably the best way forward and should be applied. > > Thanks. Nicolas asked me to add tests for this patch. But I need to look > into how to add tests for behavior of bindings. Need to add tests for M-j > binding behavior when cursor is within a comment or outside. FWIW I have been running the equivalent of Kaushal's patch (I just removed the local binding of comment-line-break-function to 'org-comment-line-break-function without deleting the function) and have also set (debug-on-entry 'org-comment-line-break-function) I've been running this for at least a week with no issues, and have never been dropped into the debugger. So at least the testing through my normal work indicates there are no problems with the patch. -- Best, Richard