From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CIZIOPsj7mJuHQAAbAwnHQ (envelope-from ) for ; Sat, 06 Aug 2022 10:19:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id iOFYOPsj7mJ4YQEA9RJhRA (envelope-from ) for ; Sat, 06 Aug 2022 10:19:07 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B562A3CAA for ; Sat, 6 Aug 2022 10:19:07 +0200 (CEST) Received: from localhost ([::1]:34208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oKF1W-00069u-Ur for larch@yhetil.org; Sat, 06 Aug 2022 04:19:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oKF11-00063y-Gw for emacs-orgmode@gnu.org; Sat, 06 Aug 2022 04:18:35 -0400 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]:38825) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oKF0z-0007To-VP for emacs-orgmode@gnu.org; Sat, 06 Aug 2022 04:18:35 -0400 Received: by mail-pl1-x635.google.com with SMTP id o3so4464538ple.5 for ; Sat, 06 Aug 2022 01:18:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=TtndvoX3FmlTUlCiLqz5KdgNjuzzWywOr1Xhyj+TWMs=; b=LJbcGhLb2bZvhdJUtYHnxrO1XNqcNfWS8WzDGorNJmIFPFY7U64NASC3+AOdJidcJX 11SDOpcFD8H/cveJpQGdD5gMGFWCOriCSlDk8YCO/3apEaXUhGNeArdYq98/m2FC8DYr wVVYg0Mb8I9BcWnzYvNZcb78qfQpUQpHxWHjMsX+iz1g8Lq5mgYZAA7eZcOnr+nnwCT/ cq+IvqJ6j/EbExdRbeBlNpMyrxvvA6j6tCt7ss7ZXcfpkMr3lACxshfZIKpKibWEKJW4 8RUrYg/U1Gp86M+Nc3LT3vy3sOGxnrtklRHScTYdmw/Pf2tcm1/BUCVfo1RG2xz1AMqo LQmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=TtndvoX3FmlTUlCiLqz5KdgNjuzzWywOr1Xhyj+TWMs=; b=qBOdOd1uQ+oxH50RV2TAYd+5/iSmGckEW2TbBUYUfGZQ51Kb+M5kTc3tqUkz4MPauH 7/N6jMkVHoqUDhVavNdPNelemE07BHypkvVtCmG4+S52jqHZHRSbx3Y7Exs0IWKrZmRj GRzI9S/r3C5xghlultkiwUEqmWPfEgBHMrc6NJayXPol2fB9oOPuvdUYn3sEP6ak0PCD J3iLLZNGFIubgDXTIErVbbYkipLFYjUUCuwLa0H3bQKKC3gexAY/CrCzzLs9uK5BYRTJ oACIRW/o0JT3qrf2XCtMs3/pjR03223MNMIKNa2ELlopfUBVUcJw5FkgD39lze0VEYSX oi5g== X-Gm-Message-State: ACgBeo1tVik7HDxeYmAZdWdlUFREyrrnYr+zWly+ndQeRt2jV1Po0Kwr aSgmuH0D2HLvwlDVh/8udktME/ig8yM= X-Google-Smtp-Source: AA6agR7wjo+CpGFwgI3tKA/yqc8E+R1m8B3qIsSy7EazuqqP+L/YbvVFy4zgnp8bzCl0ymdUgARm6g== X-Received: by 2002:a17:90b:3b8a:b0:1f5:56c3:54ac with SMTP id pc10-20020a17090b3b8a00b001f556c354acmr11703724pjb.2.1659773912293; Sat, 06 Aug 2022 01:18:32 -0700 (PDT) Received: from localhost ([1.83.155.1]) by smtp.gmail.com with ESMTPSA id 2-20020a631942000000b0040d0a57be02sm2631180pgz.31.2022.08.06.01.18.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Aug 2022 01:18:31 -0700 (PDT) From: Ihor Radchenko To: Joseph Turner Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH v2] lisp/ob-plantuml.el: Insert results in buffer In-Reply-To: <87fsiajvp5.fsf@breatheoutbreathe.in> References: <20220803190245.26056-1-joseph@breatheoutbreathe.in> <87zggjnudw.fsf@localhost> <87fsiajvp5.fsf@breatheoutbreathe.in> Date: Sat, 06 Aug 2022 16:19:30 +0800 Message-ID: <87v8r5lr71.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=yantar92@gmail.com; helo=mail-pl1-x635.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" Authentication-Results: aspmx1.migadu.com; none X-Migadu-Scanner: scn0.migadu.com X-TUID: pPX3ZrXzS1yg Joseph Turner writes: > Ihor Radchenko writes: > >> Let's take this opportunity and fix another omission in ob-plantuml. >> :results may generally contain Elisp sexps to be evaluated and the whole >> split-string busyness is not accurate. Please use :result-params list >> instead of :results. > > Good catch! I will submit a v3 patch. Is this still a TINYCHANGE or > shall I do a copyright assignment? WORG does not have the copyright requirement. As long as your contribution to Org core does not exceed 15LOC, you are good to go with TINYCHANGE. Of course, having copyright assignment will be good to have if you plan to submit more patches. -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92