From: "Samuel W. Flint" <swflint@flintfam.org>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: Org-Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH v2 1/2] lisp/org-clock.el: Make switching states on clock-in/-out easier
Date: Fri, 28 Oct 2022 10:03:44 -0500 [thread overview]
Message-ID: <87v8o4at2n.fsf@flintfam.org> (raw)
In-Reply-To: <87lep1ooxc.fsf@localhost> (Ihor Radchenko's message of "Thu, 27 Oct 2022 04:45:03 +0000")
>>>>> Ihor Radchenko writes:
IR> "Samuel W. Flint" <swflint+orgmode@flintfam.org> writes:
>> * lisp/org-clock.el (org-clock-in-switch-to-state,
>> org-clock-out-switch-to-state): Allow
>> `org-clock-{in,out}-switch-to-state` to be an alist of
>> current/next-state pairs.
>>
>> (org-clock-in, org-clock-out): Add logic to handle
>> `org-clock-{in,out}-switch-to-state` as alists.
IR> Thanks!
IR> Before we continue, could you please confirm if you have FSF copyright
IR> assignment? My records show that you have made two commits to Org mode
IR> previously, and they total LOC is 15, which is maximum allowed
IR> contribution that does not require copyright assignment. See
IR> https://orgmode.org/worg/org-contribute.html#copyright
I've sent in the assignment, but I'm waiting on the FSF's response & a
waiver/documentation from my employer.
>> "Set task to a special todo state while clocking it.
>> The value should be the state to which the entry should be
>> -switched. If the value is a function, it must take one
>> -parameter (the current TODO state of the item) and return the
>> -state to switch it to."
>> +switched. It may also be an alist of `(CURRENT . NEXT)' pairs.
IR> Maybe "`(CURRENT . NEXT)' TODO state pairs"? It will be slightly more
IR> clear.
>> (defcustom org-clock-out-switch-to-state nil
>> "Set task to a special todo state after clocking out.
>> The value should be the state to which the entry should be
>> -switched. If the value is a function, it must take one
>> -parameter (the current TODO state of the item) and return the
>> -state to switch it to."
IR> Same here.
I can adjust that as well. That would definitely clarify the documentation
IR> The rest looks good.
IR> If you can, please also add tests.
I'll try my hand at it!
IR> --
IR> Ihor Radchenko // yantar92,
IR> Org mode contributor,
IR> Learn more about Org mode at <https://orgmode.org/>.
IR> Support Org development at <https://liberapay.com/org-mode>,
IR> or support my work at <https://liberapay.com/yantar92>
Sam
--
Samuel W. Flint
4096R/FA13D704
(F50D 862B 4F65 5943 A8C2 EF0E 86C9 3E7A FA13 D704)
λs.(s s) λs.(s s)
O< ascii ribbon campaign - stop html mail - www.asciiribbon.org
next prev parent reply other threads:[~2022-10-28 15:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 14:53 [PATCH v2 1/2] lisp/org-clock.el: Make switching states on clock-in/-out easier Samuel W. Flint
2022-10-27 4:11 ` Max Nikulin
2022-10-27 4:45 ` Ihor Radchenko
2022-10-28 15:03 ` Samuel W. Flint [this message]
2022-10-29 3:51 ` Ihor Radchenko
2022-11-21 9:06 ` Ihor Radchenko
2022-11-21 14:53 ` Samuel W. Flint
2022-11-22 3:36 ` Ihor Radchenko
2023-01-27 10:38 ` Ihor Radchenko
2023-07-16 8:22 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8o4at2n.fsf@flintfam.org \
--to=swflint@flintfam.org \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).