emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Ihor Radchenko <yantar92@posteo.net>
To: Bruno Barbier <perso.bruno.barbier@free.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-babel-insert-result: Fix wrong-type-argument markerp nil
Date: Wed, 09 Nov 2022 02:33:02 +0000	[thread overview]
Message-ID: <87v8noc0wx.fsf@localhost> (raw)
In-Reply-To: <E1osT57-0000BJ-OT@lists.gnu.org>

Bruno Barbier <perso.bruno.barbier@free.fr> writes:

> Here is a small patch for a corner case in `org-babel-insert-result'.

Thanks, but could you please explain a bit more about this corner case?

> lisp/ob-core.el (org-babel-insert-result): Don't reset the marker
> `end' if it is not defined.

`end' must be always defined because
(setq end (copy-marker (point) t))
must be executed.

Nothing must ever set `end' to nil. Otherwise, a couple of other places
in code will also be broken.

Your patch, if addressing a valid scenario, is not treating the root
cause; just the symptom.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

next prev parent reply	other threads:[~2022-11-09  2:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08 18:17 [PATCH] org-babel-insert-result: Fix wrong-type-argument markerp nil Bruno Barbier
2022-11-09  2:33 ` Ihor Radchenko [this message]
2022-11-09  6:37   ` Bruno Barbier
2022-11-09  6:42     ` Ihor Radchenko
2022-11-09  6:44       ` Ihor Radchenko
2022-11-09  6:59         ` Bruno Barbier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8noc0wx.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=perso.bruno.barbier@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).