emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Damien Cassou <damien@cassou.me>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] [PATCH] org-odt-plain-text: Fix when text contains only spaces [9.7-pre (release_9.6.4-346-g7d41bd @ /home/cassou/.emacs.d/lib/org/lisp/)]
Date: Sun, 30 Apr 2023 17:27:33 +0000	[thread overview]
Message-ID: <87v8hdz3ei.fsf@localhost> (raw)
In-Reply-To: <87ttwxphm6.fsf@cassou.me>

Damien Cassou <damien@cassou.me> writes:

> in [1], Ihor fixed a bug I reported in ox-odt. Unfortunately, this fix
> broke figures with several lines of captions such as:
>
>     #+CAPTION: first line,
>     #+CAPTION: second line
>     [[file:media/myPicture.png]]
>
> This is because, in this case, org-odt-plain-text is called at some
> point with " " as value for `text`. In this context, both `leading` and
> `trailing` temporary variables contain the same value as `text`, making
> the `substring` call crash.

Thanks for the heads-up!
Fixed, on bugfix. Alongside with a couple of ox-odt improvements on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=c756f8a85

https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=c265d964f
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=a686c7b60

> The attached patch fixes the issue by considering that there is no
> leading/trailing content when the input only contains spaces.

I used an alternative approach.
Canceled. (for the patch)

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


      reply	other threads:[~2023-04-30 17:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-30 14:30 [BUG] [PATCH] org-odt-plain-text: Fix when text contains only spaces [9.7-pre (release_9.6.4-346-g7d41bd @ /home/cassou/.emacs.d/lib/org/lisp/)] Damien Cassou
2023-04-30 17:27 ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8hdz3ei.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=damien@cassou.me \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).