From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id IBL4AsNMY2Q8wAAASxT56A (envelope-from ) for ; Tue, 16 May 2023 11:28:35 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id wN2vAsNMY2QEEQAAauVa8A (envelope-from ) for ; Tue, 16 May 2023 11:28:35 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C29D0ABA4 for ; Tue, 16 May 2023 11:28:34 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pyqyA-0002tZ-9H; Tue, 16 May 2023 05:27:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyqy8-0002l6-FR for emacs-orgmode@gnu.org; Tue, 16 May 2023 05:27:44 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyqy6-0003vK-D1 for emacs-orgmode@gnu.org; Tue, 16 May 2023 05:27:44 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 4931F240112 for ; Tue, 16 May 2023 11:27:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1684229259; bh=U8bYl1wDnn1fAh54sywRUTCYiZ6ULqbjrbFX2VDCJVw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=agFnwDmhGTfGFGbLJf6XVoG7bhgs6h6uLF8YO6fSBKogFm2KJ1N1xZ9cCPn/S/oAW qfop/n6XOouDuOvSKTJx9legsVYlPNIXMjlWU8h9axWeuHXv49qA3zAJv0x7fam4Rj 7iZYXJkHDQRKy2dMsbkYe2aCeyJAR5wWamd74Dy/FA/kj4PczS4QmGhTDSxxpz9vXZ e7oV5MvCGA/V6Mtq1TcIHe0a+A3RjRx3gQxXmpyHjzdoek4FJVdt2EXupv26S+hBUi eiZ1oBmE2//nClNzzNqPZQ5o7Rpy01GC19XleGbK6/+QBktiki7piA04JV+BfeNvgg wUH+O8azifX/Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QL9r85J1Rz6tys; Tue, 16 May 2023 11:27:36 +0200 (CEST) From: Ihor Radchenko To: "Christopher M. Miles" Cc: Org-mode Subject: Re: [PATCH v3.1] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist` In-Reply-To: <64625a39.620a0220.e2d74.706d@mx.google.com> References: <878rds1xta.fsf@localhost> <87a5y8iiak.fsf@localhost> <645fc094.170a0220.4d545.38e1@mx.google.com> <87wn1cgjij.fsf@localhost> <64604168.170a0220.99926.5b4f@mx.google.com> <87lehrgwqn.fsf@localhost> <6460f5e3.630a0220.b9085.17d2@mx.google.com> <87ilcvdknx.fsf@localhost> <64611586.a70a0220.53db4.4151@mx.google.com> <871qjiiziz.fsf@localhost> <64612e34.170a0220.28faa.5dcb@mx.google.com> <87v8gthnc9.fsf@localhost> <64624762.170a0220.fd372.5c0d@mx.google.com> <64625a39.620a0220.e2d74.706d@mx.google.com> Date: Tue, 16 May 2023 09:31:03 +0000 Message-ID: <87v8gs4o88.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684229314; a=rsa-sha256; cv=none; b=C8t2dNZXTzVyw+VZP78BvP4qBzKC9s06bDj4A1Oe7JURJ50DwbB8CtkhOKXfHTNG2Ixash AP5bGiSvzbpHqKQV7bSDO4YIKKmnqTDyxPN2hGVe6KbgaDBIFrv5joc0bFVHGOWOpfonP3 1t1VrQt1gcqESVozHfkrVA8DVP+9im5fuib0GUFTor9Qtnoh8nU83qs92u4VX6Aizr0mFe b8IFgDGVNC6PBz4o84DkEFUQzMKnKTSvjs6Pqecs4yYsUXM/OMBDbbwSHd5xr9b29+00rM 9cCfy0Ts8KKyi44gHvDsw0gKVsS604jexfUKcUxiH25YoyYrDT1x0wVDiD2n+w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=agFnwDmh; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684229314; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=LvUH8UuqeoWOk9HKSna/9tER4Jmr1HfhyBOFjeHKtwI=; b=gnvnNFaJWUXzjLVNRiGfwZhaZcqjuTeMQAMvtrB4Xpkv82dA+RtpNFTeDd64HQL8OUjCN5 Z+2Bs2IBZnDdbsmaoTUV/MKTBTXjsVBJopIlZiWjjXvS1joqPOiVoDjhrVZ65+tCSv78TL rF/N2p0+0PIoYZcdaDQG4IoAKgIN94GUdr8oVfnhp7AHE69xsmCR/U9u6c2qvI7+YiODUd SLCq4re1K0SzVHxlTOVtlsCydL6/zqaZyey+Ag53W73FLC8UREnBEMDGC2a9icK8rAUcvg O/XAPgywyu7As5E0T/2sImZwdm7iANhBcaZ0R6K7EPT6bZqdM30bXu+zvTBKTg== X-Migadu-Spam-Score: -5.89 X-Spam-Score: -5.89 X-Migadu-Queue-Id: C29D0ABA4 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=agFnwDmh; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-TUID: YcVycBaw6Rg9 "Christopher M. Miles" writes: > Updated version which fix the `message` error in upper code: Thanks! > #+begin_src emacs-lisp > (setq tbl (let ((bound-tags (seq-filter 'cdr fulltable))) > (if (length< fulltable org-fast-tag-selection-maximum-tags) Because of (:startgroup) markers and similar things, this condition is not fully accurate. See `org-tag-alist' docstring. You may also need to consider special alist items in the rest of the code. > fulltable > (if (length< bound-tags org-fast-tag-selection-maximum-tags) > (progn > (insert "Tags are limited displayed by `org-fast-tag-selection-maximum-tags'.\n") If you want to have proper Elisp symbol markup when using `...', use `format-message'. > (seq-take (seq-uniq (append bound-tags fulltable)) > org-fast-tag-selection-maximum-tags)) This will behave awkwardly with tag groups. You may better use `org--tag-add-to-alist'. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at