From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id yLvyAUNctmQmSwAASxT56A (envelope-from ) for ; Tue, 18 Jul 2023 11:32:51 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id YPz3AENctmQ+tAAAG6o9tA (envelope-from ) for ; Tue, 18 Jul 2023 11:32:51 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A33F641B3C for ; Tue, 18 Jul 2023 11:32:50 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="C/VuEibR"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689672770; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HkkldRkobtsPe2monlF0JYsep1nMbRoPO87m2Uhal+I=; b=MWde8E5rofWdkt06vCprv3sS98pT2UVdXVn9G4GEivVAM+HEc0Qomf9Gaz/rEhGofvjVFP o87MaJmgXvb1LwhjU2W1s/DSmfZcqaQs0OgmghmaT5L5HI79CJEaO3MWtiisLNDJJZKj0W qwPYC/lxeInFzst+g32lhjkqp3pWRcbQgZlMW2OblXOOBSMDRo++x0ADsLAm1WmiPAVHHD gBuflg/li81hmboCvqWUIZkO9RTA/xVIAARa3oOzP3/Hbz3v+jF3NeI+cP8DL6cM+hS2Nb 7vEVxtJeBWpzEGu+f2Gdqz1UxqH71ndOkBMD031rUdnMzesr2bSvHh+ZSFCNdQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689672770; a=rsa-sha256; cv=none; b=d0C7kYJVyWSSZc/mokexAwVSoA67lC+ao2p0nFUmAQuDSZXjJwLIe0061NyiPLk4/Cs1I8 xYCjv/zMUakj9y3sSILyDzs1HEugRJDAgpI+sLgC4OYYpX728uSgiPSiOrZlszYNKd5Grq krb37Z2Qael9e0KDgn4BKwE0Ae9fhZCHib/5Dqwydi/ZjGsWw7FlNmGzQtiqgrZ4PsDdB3 VXqBB2MJZisYGvJcAG91xxyrKQx12/eMCPaW9djB23c4Fq2UIqn3P9bORbYe4kMoNOgw4d Yv3QFlqAGJoB7FNHw0LK4O4YiRpUbAOGAqUQlephAn2PWRA4sJEl9OyJMXNMrg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="C/VuEibR"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLh3D-0004AH-R5; Tue, 18 Jul 2023 05:31:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLh36-00049R-A1 for emacs-orgmode@gnu.org; Tue, 18 Jul 2023 05:31:17 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLh34-0004VE-06 for emacs-orgmode@gnu.org; Tue, 18 Jul 2023 05:31:16 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id DB3C4240028 for ; Tue, 18 Jul 2023 11:31:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689672671; bh=cNmZlz/OJdz3X4afPfR7cDk2O6AMQ2sLJzp9jFsAtvU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=C/VuEibRuYikvD9uCTjawX14fKYUq/es270+Sx/Gzo4dUzYE2HYnhzp1gSyqkYtr8 WmZiEORgIaCZGidCAOeo6GAVGQNDe5uYbxhIRhK+2LCoZ5ix7r/6C+IZlKl5Og+qLe KVIP5su6MfwZKqLCtcnJMkWaq/bjjdjNcmBO2h0sdtO6idVqt7tom8YiRcRQh3Z23c /wJUHfk7vVJ6gpAGZ6bIjvzsDHXiphipI8OXMsH8O33AsC6eiRpPXDx8pcQfLo4vM4 HRIUfh8qLJQmEVTmt8fb6KvkfclgmuoARTbKqfwGTY3RYIu4FFxn2pmfs+LXz5eC5w MUAnbfQ522ccA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R4txC16wBz6tvv; Tue, 18 Jul 2023 11:31:10 +0200 (CEST) From: Ihor Radchenko To: Morgan Smith Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Testing: Add tests for 'org-agenda-check-for-timestamp-as-reason-to-ignore-todo-item' In-Reply-To: References: Date: Tue, 18 Jul 2023 09:31:21 +0000 Message-ID: <87v8ehva52.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -5.54 X-Spam-Score: -5.54 X-Migadu-Queue-Id: A33F641B3C X-Migadu-Scanner: mx1.migadu.com X-TUID: gwI6qKFDV9Wl Morgan Smith writes: > * testing/lisp/test-org-agenda.el > (test-org-agenda/check-for-timestamp-as-reason-to-ignore-todo-item): > New test. Thanks for the patch, but I am not sure if what we want to test is this function. `org-agenda-check-for-timestamp-as-reason-to-ignore-todo-item' is semi-internal function, which is simply serving to group some common skip tests together. It will be more reliable to test the final agenda behaviour - what is display in the actual agenda view and what not. Basically, instead of testing the return value of `org-agenda-check-for-timestamp-as-reason-to-ignore-todo-item', test using `org-test-agenda-with-agenda' and check the agenda buffer contents. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at