From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id OCGFJljBJmU2BQEAauVa8A:P1 (envelope-from ) for ; Wed, 11 Oct 2023 17:38:00 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id OCGFJljBJmU2BQEAauVa8A (envelope-from ) for ; Wed, 11 Oct 2023 17:38:00 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3BDDD52876 for ; Wed, 11 Oct 2023 17:38:00 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DegMcrV7; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697038680; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=xIsh/sWD+xrHIevT7p2LmX2o8AgnGstgfXtBM/8sAtE=; b=AVsWxzh1w0uOaa7X2ZGh2mUApimbn2Qnrnp7dW1X4FexNrLKKjL+Jqr7c2fNaWsoNt6ivu hciVSEt9eR+JNAw/Yw9TxQq0ZHEmzKbCgmHgXY4y+KCj2GwFRGxg+EJd4LlhgbE4BPwK6n j1KFmcepfZV5b/sR1ZErmx6baZG//zRCUKnScFrXcTZ9RHe2ruDohaDvnBzz6ExYChJ35a RuQ4cSa5x0HBqzP7tO18FFHEVoG5ee0MLElC5K4z1JLIcy8EM9aAtTJ/5AcBqfBXiVipZc 5QSiMBpL8G4eJgbb7Cys3Mj2WAvoNEYTV/4aBx0BNSxCzE2rdmsbDxgVqxxbBA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DegMcrV7; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697038680; a=rsa-sha256; cv=none; b=FsAKsMR21OiYhwl04k9K3eZ5lEI8Prtsyl+gCdpuAEMzHl1qJbkb+qCt5+j5pkuWxIDm4O 39fz97wOZqFOVLLISdwSfcOX+pKUWzizzvYXY4BgoplsvWHc7i3ekHzeeZRt+jcuGhkRgn quqZJvki/2HcX9Px8i7gSWbKH8lUIkqt6yfaOctZhRnhi4P0D/64RW4v1AUOfs5GpiRjbz Ju8UVy7cpsFvflAQxYjhuHw7oC4XACr9aogU5UT6YKg0tEeOVDKFABGYvfTpSJjEo2RtQZ ohuavYX5oKMqX2lNG//7j9Bh+oEpjXTvE7etdX908dxx6fXkk6KwvvG5uF9Z/A== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqbGo-0007QI-HV; Wed, 11 Oct 2023 11:37:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqbGf-0007Mz-2R for emacs-orgmode@gnu.org; Wed, 11 Oct 2023 11:37:01 -0400 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qqbGc-0001RA-Vx for emacs-orgmode@gnu.org; Wed, 11 Oct 2023 11:37:00 -0400 Received: by mail-pl1-x642.google.com with SMTP id d9443c01a7336-1c888b3a25aso46480445ad.0 for ; Wed, 11 Oct 2023 08:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697038617; x=1697643417; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xIsh/sWD+xrHIevT7p2LmX2o8AgnGstgfXtBM/8sAtE=; b=DegMcrV7/zZkqBYL4qRtDzZXg3pvQngwbuL0UXaBPB6nPQNbLPNHNGYgax3/jtMvCh wFo3g89bQnaEQvEwjynORMXssk0nUW8wYhJLYf0QkYz2X1HTndS3oTCBhaU6Moo9wItW QCq4+v55hRJB3bK3bIx7HduwJki0pVP2xT7UOTusdIkAPyHfx6bE0/9gu6RslLbZehyf JWOJi9WedGf3pCXyAs1xXh4KWMLO9FshlNhUxDuJjf9yXUFlxVqFG+ztbuLFke65iZdI xhhqwJbHYZ5MkjG661URmByhOzXB/1E0fUH9SnrJqfIwwD/SVV5UPYFIocEAUZKY61m8 AIiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697038617; x=1697643417; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xIsh/sWD+xrHIevT7p2LmX2o8AgnGstgfXtBM/8sAtE=; b=tjvoEw9QdH1y+oIUxwMI7GsDHMRFPNDpXcNkSZmCawGgi2fEnNnTnOYUk8TRG1enS+ gy3jJyhkZun6N6k8qbtAfqpMYof+ykdZ2Gj639azAu0jpZf8CVdkKIsElpYNKuejc+T3 okLJN3A2ta0bjzHqdA6hTKQuyRF8U57E5rNb/KkAJ+nP2LyXFvbTcEFbQeQjrhB+15Nk 4MnpxFuBXMEU8vRglToTlHfTfspyMgEQ/IU8uYWuQ+9cbh8cZz3ORrcj6EVMkDRvO4Mx o6oWNvPv3136j4upNhRZJ5bpZPjinnnmoy+B8a6X0zwQvX5JCFUUrAKq4H7reOZuHgYB 5ESw== X-Gm-Message-State: AOJu0Yywz+fkgXe+VRnTXcaaCIk/kWLGMf2ruSG1XDU7eg6uOecv07Zp c5URzoBLGvcQtcJXyJFEWr4= X-Google-Smtp-Source: AGHT+IEuOWvXSBUEW6upQt4HfQzsEYmXwynCKTkTWHTCvbUGybARz/lPujE2JIBPRr/1u7jZpcQmbw== X-Received: by 2002:a17:903:2441:b0:1c3:61d9:2b32 with SMTP id l1-20020a170903244100b001c361d92b32mr22045611pls.45.1697038616408; Wed, 11 Oct 2023 08:36:56 -0700 (PDT) Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id z11-20020a170903018b00b001bdeb6bdfbasm14118258plg.241.2023.10.11.08.36.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 08:36:55 -0700 (PDT) From: Visuwesh To: Liu Hui Cc: emacs-orgmode@gnu.org, Ihor Radchenko Subject: Re: [BUG] [PATCH] Add yank-media and DND handler [9.6.7 (9.6.7-g6eb773 @ /home/viz/lib/emacs/straight/build/org/)] In-Reply-To: (Liu Hui's message of "Wed, 11 Oct 2023 22:24:07 +0800") References: Date: Wed, 11 Oct 2023 21:06:53 +0530 Message-ID: <87v8bd188a.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::642; envelope-from=visuweshm@gmail.com; helo=mail-pl1-x642.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -7.50 X-Spam-Score: -7.50 X-Migadu-Queue-Id: 3BDDD52876 X-Migadu-Scanner: mx2.migadu.com X-TUID: karBv8BqvbQb [=E0=AE=AA=E0=AF=81=E0=AE=A4=E0=AE=A9=E0=AF=8D =E0=AE=85=E0=AE=95=E0=AF=8D= =E0=AE=9F=E0=AF=8B=E0=AE=AA=E0=AE=B0=E0=AF=8D 11, 2023] Liu Hui wrote: > Hi, > > Thanks for your work. I have two minor suggestions about the patch. > >> + (`file-link >> + (let ((filename (dnd-get-local-file-name url))) >> + (insert (org-link-make-string (concat "file:" filename)))))))) > > I think it is better to abbreviate the file name for file-link, so it > would be consistent with org-insert-link. OK, will do. >> + (caddr (read-multiple-choice >> + "What to do with dropped file?" >> + '((?a "attach" attach) >> + (?o "open" open) >> + (?f "insert file: link" file-link)))) > > The dialog box is shown in the center of frame and I find it a little > inconvenient compared with a menu popped up just at the mouse > location. How about using x-popup-menu? But isn't that for menus? I don't know how convenient is a menu compared to a dialog box. But if the consensus is that a menu should be popped, then I will adjust the query to use rmc or menu as per use-dialog-box.