From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id EBxcLJ2Z2GWThAAA62LTzQ:P1 (envelope-from ) for ; Fri, 23 Feb 2024 14:11:57 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id EBxcLJ2Z2GWThAAA62LTzQ (envelope-from ) for ; Fri, 23 Feb 2024 14:11:57 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=g3vtKRaC; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708693917; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=kx6q85uM5brFPE8Cp4gjkrmVg7zNKAkQgfUt5uZR7rw=; b=Z9ghxKt5LekZUVD4qUa/GFWurUuQjlOYGVfXam1wwYcnwRqJkavD20F6y8H28MdCP8AhZL UDaczTe2wn3r10nRCFD0Qu9FibTwlBMYGgmGP07Uv7VIVpqvt55bjpQzPl8JmaDvzbgpl3 JKM77P6uy9BgBzVLNM9w06jiss6wvrovksEo4OLETa2lZNvwjnq31Si36pElboCEFJIAgp kXZocp5I3IDDSP7TA6zwLj1iSjZ5QaozvPGNPTwymCo7mk9r7YFJohuCE5pI/xbYDuw6qL zvhV7i4F1VKdVqu82saSp15T+VBbicK8FsVqoP4P/exnwEhTwe9uFvmyzNlHEw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=g3vtKRaC; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708693917; a=rsa-sha256; cv=none; b=LxGbGa9aq8k1YuxrNWpgVYtTqSLTHzpOpUoqyDPipFAclnqfe4HMOqu0phaRUZfUzaIDrA TROHmG25i/O7j96cVEVhav8qgiEaevUecNqKPjtyAaaK9vx0mwPv8wYK481iCM9892N8e1 8SvNuI1Mcr7O4DorL/yPo7EO0Vjnra9AUgT2lDPCCRi8/QDQsgbuPsYPdCBAFap93KnxsG /xAbe8DU0Qjew+w4/npxawLbixO4kNo5NoKxRWvxPMfF2x3yCiN+bK1mKV2mP7YEy7DgpH 8W6Y/wJxGpqHaMGkW1lykkpCQt6sSsF3Pcqx0PG6tsP4HcRgadAGisqWFtgRvA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5EDA326ECF for ; Fri, 23 Feb 2024 14:11:57 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdVKA-0002eF-CX; Fri, 23 Feb 2024 08:10:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdVJV-0002Xt-Os for emacs-orgmode@gnu.org; Fri, 23 Feb 2024 08:10:05 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdVJQ-0000CO-AD for emacs-orgmode@gnu.org; Fri, 23 Feb 2024 08:10:05 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 96775240103 for ; Fri, 23 Feb 2024 14:09:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1708693797; bh=kP38zG8cCzGIxrQTbxLqYgNWGYNLIGeBVNA9ZxqOpwc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=g3vtKRaC9IQLGlezIRHQNWj+mhOGP0mqeaEFzCzsBiJktWHTueKPwAC7DT9Z/qxKU XiZi6oEy/spUk5StUhP667a8YSYwDS0ZNd5PMkXQNR2Vcf74L/ei8NAwDeP9JGJ9g+ nAeIwIQ1nPltwLTsSWFiUyJFaIGgrDS6JO72PEQb2hKL5lq++MuHLtTxXYHNkVAopj 83XWuQ5ibWSyHlvNU5Hak5rjYBfc6ytI4H8qC8kVvKh9TuzK3Twl/xPxeuYiGmUmsk F4DGMfQS29hBLM78r+jk0xD7TghYSaJDNOUqoN5Tt11tzhz1CMJrJepL5gF7it9nA4 7nVSK/1yX8vZg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Th9N45rqtz6tv5; Fri, 23 Feb 2024 14:09:56 +0100 (CET) From: Ihor Radchenko To: Nathaniel Nicandro Cc: emacs-orgmode , Rudi C Subject: Re: [PATCH] Handle block-type when checking `org-src-fontify-natively' In-Reply-To: <87zg7lghzz.fsf@gmail.com> References: <87zg7lghzz.fsf@gmail.com> Date: Fri, 23 Feb 2024 13:13:40 +0000 Message-ID: <87v86fiarf.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -5.59 X-Spam-Score: -5.59 X-Migadu-Queue-Id: 5EDA326ECF X-TUID: PVLQ0XxEdo7b Nathaniel Nicandro writes: > I think I found a bug where the condition for `org-src-fontify-natively` > in `org-src-fontify-meta-lines-and-blocks-1` wasn't handling the block > type. `org-src-fontify-natively` says it should fontify src blocks > only, but the condition didn't have that constraint. Attached is a > patch that adds in the constraint. It turned out, that some people relied on the undocumented behavior that Org mode fontifies example blocks as well. https://orgmode.org/list/CAE9z9A3ko27NeN0oYFs_aBWV_cUbNm5YQTLrRux16dHsixsMBA@mail.gmail.com Nathaniel, is there any particular problem you encountered that your patch was aiming to solve? If no, we should probably re-add fontifying example blocks as undocumented feature people rely on in practice. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at