emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Tassilo Horn <tassilo@member.fsf.org>
To: emacs-orgmode@gnu.org
Subject: Re: ECB and org-mode
Date: Wed, 14 Oct 2009 19:57:42 +0200	[thread overview]
Message-ID: <87tyy1zwmh.fsf@thinkpad.tsdh.de> (raw)
In-Reply-To: 87iqehhp2n.wl%ucecesf@ucl.ac.uk

Eric S Fraga <ucecesf@ucl.ac.uk> writes:

Hi Eric,

> (defadvice ecb-method-clicked (after esf/org-show-context)
>   "Make sure hierarchy is visible when jumping into location from ECB tree buffer"
>   (if (string= major-mode "org-mode")

Here, you want (eq major-mode 'org-mode).  Your version also works, but
only because string= converts symbols to their string name, and the
value of `major-mode' is a symbol.  The `eq' version is more efficient,
but mostly it's for style reasons.

> Again, apologies for my minimal (yet increasing) elisp knowledge!

Hey, it works!  What do you want more? ;-)

Bye,
Tassilo

next prev parent reply	other threads:[~2009-10-14 17:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-12 12:32 ECB and org-mode Eric S Fraga
2009-10-12 13:06 ` Carsten Dominik
2009-10-12 15:31   ` Eric S Fraga
2009-10-13  8:00     ` Carsten Dominik
2009-10-13 19:07       ` Eric S Fraga
2009-10-14 17:18       ` Eric S Fraga, Eric S Fraga
2009-10-14 17:57         ` Tassilo Horn [this message]
2009-10-15  6:52           ` Eric S Fraga, Eric S Fraga
2009-10-20 10:28         ` Carsten Dominik
2009-10-20 16:11           ` Eric S Fraga
2009-10-20 16:14             ` Carsten Dominik
2009-10-20 16:24               ` Eric S Fraga
2009-10-20 16:22             ` Carsten Dominik
2009-10-20 16:29               ` Eric S Fraga
2009-10-20 16:34                 ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tyy1zwmh.fsf@thinkpad.tsdh.de \
    --to=tassilo@member.fsf.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).